-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathlinker Subnetwork Generation - Conflict with Phenoscape #33
Comments
PathLinker #33: Apply style of the current network to the subnetwork
I performed another test, and discovered that the default style values are applied correctly to the ksp subentwork, but the "bypass" styles are not. We need to figure out how to fix this. |
Found the documentation for setting a Looks like all we need to do is loop through the nodes and edges of the subnetwork and use the |
Scooter Morris gave an answer |
… down the bypass layouts
…tings, now need to pass subnetwork reference to result panel instead of current network
…ntNetwork for clarity purposes
…lectKSPSubgraph for clarity reason; update comments accordingly
Pathlinker #33: Apply style of original network to pathlinker subnetwork
The |
Li implemented the Scooter's first suggestion by setting the sub-network to the selected network as the generated sub-network is automatically selected with However, this current implementation is buggy if the Phenoscape App is open. Specifically:
These issues should go away if we use Scooter's second suggestion to generate the sub-network. |
This reverts commit aff4a13.
Issue persists with PathLinker app v1.4 and Cytoscape v3.6, even though we fixed what we could on our end |
If the original network has node and edge styles set, the PathLinker subnetwork should have those styles as well (except for the blue diamond and yellow square sources and targets). This would allow the user to better interpret the PathLinker subnetwork. For example:
A cytoscape user has edge colors set according to specific types of edges (physical, phosphorylation, ubiquitination, etc.). In our PathLinker subnetwork results, their original styles would be helpful for them to see if there are any paths of more interest to them.
The text was updated successfully, but these errors were encountered: