Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathlinker Subnetwork Generation - Conflict with Phenoscape #33

Open
jlaw9 opened this issue Jul 26, 2017 · 6 comments
Open

Pathlinker Subnetwork Generation - Conflict with Phenoscape #33

jlaw9 opened this issue Jul 26, 2017 · 6 comments

Comments

@jlaw9
Copy link
Collaborator

jlaw9 commented Jul 26, 2017

If the original network has node and edge styles set, the PathLinker subnetwork should have those styles as well (except for the blue diamond and yellow square sources and targets). This would allow the user to better interpret the PathLinker subnetwork. For example:

A cytoscape user has edge colors set according to specific types of edges (physical, phosphorylation, ubiquitination, etc.). In our PathLinker subnetwork results, their original styles would be helpful for them to see if there are any paths of more interest to them.

LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Aug 10, 2017
@jlaw9 jlaw9 closed this as completed Aug 15, 2017
jlaw9 added a commit that referenced this issue Aug 15, 2017
PathLinker #33: Apply style of the current network to the subnetwork
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Aug 15, 2017

I performed another test, and discovered that the default style values are applied correctly to the ksp subentwork, but the "bypass" styles are not. We need to figure out how to fix this.

@jlaw9 jlaw9 reopened this Aug 15, 2017
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Aug 16, 2017

Found the documentation for setting a VisualMappingFunction which is how the bypass styles are set in the VizMapper section in the app cookbook.

Looks like all we need to do is loop through the nodes and edges of the subnetwork and use the apply function to copy the "bypass" or visual mapping styles of the original network to the subnetwork.

@jlaw9
Copy link
Collaborator Author

jlaw9 commented Aug 17, 2017

Scooter Morris gave an answer

LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Aug 18, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Aug 31, 2017
…tings, now need to pass subnetwork reference to result panel instead of current network
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Aug 31, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Aug 31, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Sep 4, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Sep 4, 2017
…lectKSPSubgraph for clarity reason; update comments accordingly
jlaw9 added a commit that referenced this issue Sep 5, 2017
Pathlinker #33: Apply style of original network to pathlinker subnetwork
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Sep 8, 2017
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Sep 13, 2017

The cyApplicationManager.getCurrentNetworkView(); function did not work for us. For now we are keeping the hack to select the newly-created subnetwork (see the files changed in pull request #45). In the future it will be better to implement Scooter's second suggestion and "copy" the code to generate the subnetwork.

@jlaw9 jlaw9 closed this as completed Sep 13, 2017
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Oct 3, 2017

Li implemented the Scooter's first suggestion by setting the sub-network to the selected network as the generated sub-network is automatically selected with _kspSubgraph = _applicationManager.getCurrentNetworkView().getModel();.

However, this current implementation is buggy if the Phenoscape App is open.

Specifically:

  1. A different network is selected instead of the newly-created sub-network because of Phenoscape's network selection dropdown.
  2. The style of the other network is applied to the sub-network

These issues should go away if we use Scooter's second suggestion to generate the sub-network.

@jlaw9 jlaw9 changed the title Apply style of original network to pathlinker subnetwork Pathlinker Subnetwork Generation - Conflict with Phenoscape Oct 3, 2017
@jlaw9 jlaw9 reopened this Oct 3, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Oct 22, 2017
LHuang2019 added a commit to LHuang2019/PathLinker-Cytoscape that referenced this issue Oct 22, 2017
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Jan 19, 2018

Issue persists with PathLinker app v1.4 and Cytoscape v3.6, even though we fixed what we could on our end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant