Add SkriptLogger in constructor of registration and a finish consumer API #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/consumer-registration-done
(cherry picked from commit cf9cf7d)
…om/TheLimeGlass/skript-parser into feature/consumer-registration-done
Mwexim
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SkriptLogger in constructor of registration and a finish consumer API.
Allows for a consumer as a callback for when the SkriptRegistration finish. This can be useful to start executing or loading Scripts after all the syntaxes have been registered.
This pull also allows for setting the SkriptLogger in the consumer. This is because when registering syntaxes as i've found, the implementing SkriptAddon needs to be able to read it's own errors, rather than SkriptRegistration making a new SkriptLogger. There may be other details that are present in the provided SkriptLogger that the implementing class may need.
Also organized the fields to look pretty.