Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a test called
DruidMysqlRouteStrategyTest.testAggregateExpr
which can be found here.This test is responsible for testing the behavior of the route strategy when processing SQL queries with aggregate functions and different aliasing scenarios. It checks if the result set correctly identifies and names the aggregated columns.
This test fails because we are checking if the HashMap returned by
getMergeCols()
method contains the column name as a key while not checking for case sensitivity.This PR fixes this issue by updating the key name into uppercase.
The assertion happens here:
Mycat-Server/src/test/java/io/mycat/route/DruidMysqlRouteStrategyTest.java
Line 960 in 243539f
You can run the following command to run the test:
Test Environment: