Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover-list-beta): Focus first list item on popover show #744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jason-evans-genesys
Copy link
Collaborator

✅ Closes: COMUI-1576

Copy link

github-actions bot commented Dec 2, 2024

@gavin-everett-genesys
Copy link
Collaborator

I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear.

@jason-evans-genesys jason-evans-genesys changed the title fix(popover-list-beta): Focus first list item on popover show (WIP) fix(popover-list-beta): Focus first list item on popover show Dec 3, 2024
@jason-evans-genesys
Copy link
Collaborator Author

I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear.

@gavin-everett-genesys good call. Ok fixes pushed.

@gavin-everett-genesys
Copy link
Collaborator

I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear.

@gavin-everett-genesys good call. Ok fixes pushed.

Will approve I was just wondering did you push these changes ?

@jason-evans-genesys
Copy link
Collaborator Author

@daragh-king-genesys this PR is ready for review again after implementing the target element click changes we discussed in a recent standup.

@jason-evans-genesys
Copy link
Collaborator Author

I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear.

@gavin-everett-genesys good call. Ok fixes pushed.

Will approve I was just wondering did you push these changes ?

@gavin-everett-genesys I made these changes now.

@321gillian
Copy link
Collaborator

I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear.

@gavin-everett-genesys good call. Ok fixes pushed.

Will approve I was just wondering did you push these changes ?

@gavin-everett-genesys I made these changes now.

Can you check this again? The first item seems to still be getting focus on click for the timemachine branch

@katie-bobbe-genesys
Copy link
Collaborator

  1. I would recommend checking the behavior in Chrome as well as Firefox. The first item is getting focus on click for the time machine in Chrome (but not Firefox). We will not want the focus ring when using the mouse

  2. when the popover list has an initial open position, the focus ring is showing on the first element, which we don't want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants