-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popover-list-beta): Focus first list item on popover show #744
base: main
Are you sure you want to change the base?
Conversation
✅ Closes: COMUI-1576
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-1576 |
...ages/genesys-spark-components/src/components/beta/gux-popover-list-beta/gux-popover-list.tsx
Show resolved
Hide resolved
I think for focus rings they should only be shown when navigating via keyboard and not through mouse click. So if i click the target element via mouse no focus ring should appear. |
…listElement ✅ Closes: COMUI-1576
@gavin-everett-genesys good call. Ok fixes pushed. |
Will approve I was just wondering did you push these changes ? |
✅ Closes: COMUI-1576
@daragh-king-genesys this PR is ready for review again after implementing the target element click changes we discussed in a recent standup. |
@gavin-everett-genesys I made these changes now. |
Can you check this again? The first item seems to still be getting focus on click for the timemachine branch |
|
✅ Closes: COMUI-1576
✅ Closes: COMUI-1576