comments resolved

MyPureCloud · Jul 26, 2024 · 915a8e5 · 915a8e5
1 parent f6ff842
commit 915a8e5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/genesyscloud/integration_facebook/genesyscloud_integration_facebook_proxy.go b/genesyscloud/integration_facebook/genesyscloud_integration_facebook_proxy.go
@@ -100,6 +100,7 @@ func createIntegrationFacebookFn(ctx context.Context, p *integrationFacebookProx
 // getAllIntegrationFacebookFn is the implementation for retrieving all integration facebook in Genesys Cloud
 func getAllIntegrationFacebookFn(ctx context.Context, p *integrationFacebookProxy) (*[]platformclientv2.Facebookintegration, *platformclientv2.APIResponse, error) {
 	var allFacebookIntegrationRequests []platformclientv2.Facebookintegration
+	const pageSize = 100
 
 	facebookIntegrationRequests, resp, err := p.conversationsApi.GetConversationsMessagingIntegrationsFacebook(1, 100, "", "", "")
 	if err != nil {
@@ -112,7 +113,6 @@ func getAllIntegrationFacebookFn(ctx context.Context, p *integrationFacebookProx
 	allFacebookIntegrationRequests = append(allFacebookIntegrationRequests, *facebookIntegrationRequests.Entities...)
 
 	for pageNum := 2; pageNum <= *facebookIntegrationRequests.PageCount; pageNum++ {
-		const pageSize = 100
 
 		facebookIntegrationRequests, resp, err := p.conversationsApi.GetConversationsMessagingIntegrationsFacebook(pageNum, pageSize, "", "", "")
 		if err != nil {
@@ -149,7 +149,7 @@ func getIntegrationFacebookIdByNameFn(ctx context.Context, p *integrationFaceboo
 		}
 	}
 
-	return "", true, resp, fmt.Errorf("Unable to find integration facebook with name %s", name)
+	return "", true, resp, err
 }
 
 // getIntegrationFacebookByIdFn is an implementation of the function to get a Genesys Cloud integration facebook by Id

diff --git a/genesyscloud/integration_facebook/resource_genesyscloud_integration_facebook.go b/genesyscloud/integration_facebook/resource_genesyscloud_integration_facebook.go
@@ -84,7 +84,7 @@ func readIntegrationFacebook(ctx context.Context, d *schema.ResourceData, meta i
 		resourcedata.SetNillableValue(d, "page_id", facebookIntegrationRequest.PageId)
 		resourcedata.SetNillableValue(d, "app_id", facebookIntegrationRequest.AppId)
 
-		log.Printf("Read integration facebook")
+		log.Printf("Read integration facebook %s", *facebookIntegrationRequest.Name)
 		return cc.CheckState(d)
 	})
 }

diff --git a/genesyscloud/integration_facebook/resource_genesyscloud_integration_facebook_utils.go b/genesyscloud/integration_facebook/resource_genesyscloud_integration_facebook_utils.go
@@ -23,12 +23,6 @@ func getIntegrationFacebookFromResourceData(d *schema.ResourceData) platformclie
 	appId := d.Get("app_id").(string)
 	appSecret := d.Get("app_secret").(string)
 
-	if pageAccessToken != "" {
-		pageId = ""
-		userAccessToken = ""
-	} else {
-		pageAccessToken = ""
-	}
 	return platformclientv2.Facebookintegrationrequest{
 		Name:             platformclientv2.String(d.Get("name").(string)),
 		SupportedContent: &platformclientv2.Supportedcontentreference{Id: &supportedContentId},