Skip to content

Commit

Permalink
Remove unused message param (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
stchr authored Nov 30, 2021
1 parent 327a80d commit 370e52a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Interactor/AdaptiveInteractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ public function addCustomContext(string $name, $value): bool
return $this->interactor->addCustomContext($name, $value);
}

public function noticeThrowable(\Throwable $e, string $message = null): void
public function noticeThrowable(\Throwable $e): void
{
$this->interactor->noticeThrowable($e, $message);
$this->interactor->noticeThrowable($e);
}

public function beginTransaction(string $name, string $type, ?float $timestamp = null, ?DistributedTracingData $distributedTracingData = null): ?TransactionInterface
Expand Down
2 changes: 1 addition & 1 deletion Interactor/BlackholeInteractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function addCustomContext(string $name, $value): bool
return true;
}

public function noticeThrowable(\Throwable $e, string $message = null): void
public function noticeThrowable(\Throwable $e): void
{
}

Expand Down
2 changes: 1 addition & 1 deletion Interactor/ElasticApmInteractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function addCustomContext(string $name, $value): bool
return $this->addLabel($name, $value);
}

public function noticeThrowable(\Throwable $e, string $message = null): void
public function noticeThrowable(\Throwable $e): void
{
ElasticApm::createErrorFromThrowable($e);
}
Expand Down
2 changes: 1 addition & 1 deletion Interactor/ElasticApmInteractorInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function addCustomContext(string $name, $value): bool;
* Use these calls to collect errors that the PHP agent does not collect automatically and to set the callback for
* your own error and exception handler.
*/
public function noticeThrowable(\Throwable $e, string $message = null): void;
public function noticeThrowable(\Throwable $e): void;

/**
* Starts a new transaction.
Expand Down
4 changes: 2 additions & 2 deletions Interactor/LoggingInteractorDecorator.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ public function addCustomContext(string $name, $value): bool
return $this->interactor->addCustomContext($name, $value);
}

public function noticeThrowable(\Throwable $e, string $message = null): void
public function noticeThrowable(\Throwable $e): void
{
$this->logger->debug('Sending exception to Elastic APM', [
'message' => $message,
'exception' => $e,
]);
$this->interactor->noticeThrowable($e, $message);
$this->interactor->noticeThrowable($e);
}

public function endCurrentTransaction(?float $duration = null): bool
Expand Down

0 comments on commit 370e52a

Please sign in to comment.