Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compression of enhanced #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Radonirinaunimi
Copy link
Member

This PR implement the following changes:

  • Pre-process the enhanced set by removing duplicates (if there are).
  • Shuffle the resulting pre-processed set prior to compression while keeping track of the indices. Previously, prior and synthetics are just layered on top of each other which presumably increases the likelihood that the minimizer is trapped in some local minima.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #40 (8d9b0ba) into master (760a665) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #40   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          15      15           
  Lines        1335    1359   +24     
======================================
- Misses       1335    1359   +24     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pycompressor/compressing.py 0.00% <0.00%> (ø)
src/pycompressor/compressor.py 0.00% <0.00%> (ø)
src/pycompressor/errfunction.py 0.00% <0.00%> (ø)
src/pycompressor/utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760a665...8d9b0ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant