Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #505 - Update hooks to run YAML verification on every commit #508

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Issue #505 - Update hooks to run YAML verification on every commit #508

merged 1 commit into from
Jan 6, 2024

Conversation

MJJoyce
Copy link
Member

@MJJoyce MJJoyce commented Jan 5, 2024

Resolve #505

@MJJoyce MJJoyce requested review from a team as code owners January 5, 2024 22:12
@MJJoyce
Copy link
Member Author

MJJoyce commented Jan 5, 2024

Note, expecting builds to fail as a result of these changes until #507 is fixed

nttoole
nttoole approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@nttoole nttoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that pre_commit hook shows YAML validation error:

AIT LIMITS YAML check....................................................Failed
- hook id: limits_yaml_check
- exit code: 1

@nttoole nttoole merged commit cbdcf75 into master Jan 6, 2024
3 of 4 checks passed
@nttoole nttoole deleted the issue-505 branch January 6, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nttoole nttoole nttoole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pre-commit hooks to always run dictionary checks
2 participants
@MJJoyce @nttoole