Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #538 - Formatting and Linting #539

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

cjjacks
Copy link
Contributor

@cjjacks cjjacks commented Oct 21, 2024

Run pre-commit run --all to apply formatting to all files and updated the max line length to 120 characters

@cjjacks cjjacks requested review from a team as code owners October 21, 2024 17:44
@nttoole
Copy link
Contributor

nttoole commented Oct 22, 2024

(venv) bash-3.2$ pre-commit run --all-files
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Reorder python imports...................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
AIT TLM YAML check.......................................................Passed
AIT CMD YAML check.......................................................Passed
AIT EVR YAML check.......................................................Passed
AIT LIMITS YAML check....................................................Passed
(venv) bash-3.2$ pytest
...
============================================= 250 passed, 2 skipped, 11 warnings in 4.47s ==============================================

Successfully configured and ran AIT-GUI and ait_example:

image

Copy link

sonarcloud bot commented Oct 23, 2024

@nttoole
Copy link
Contributor

nttoole commented Oct 23, 2024

@cjjacks Just checking if this is ready for final review or if there are any expected changes? Thanks

@cjjacks
Copy link
Contributor Author

cjjacks commented Oct 23, 2024

@nttoole Sorry for the last minute update! Was just double checking and realized that I had committed updates to the lock file which didn't necessarily belong in this PR. Should be good to go now.

Copy link
Contributor

@nttoole nttoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both code review and testing via GUI plugin pass.

@nttoole nttoole merged commit 61001ed into NASA-AMMOS:master Oct 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants