-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct record linked from Campaign table #578
Merged
alukach
merged 11 commits into
feature/canonical-mi-workflow
from
bugfix/555/correct-records-displayed
Oct 16, 2023
Merged
Correct record linked from Campaign table #578
alukach
merged 11 commits into
feature/canonical-mi-workflow
from
bugfix/555/correct-records-displayed
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
force-pushed
the
bugfix/555/correct-records-displayed
branch
2 times, most recently
from
October 12, 2023 23:26
bc930ae
to
641c351
Compare
alukach
force-pushed
the
bugfix/555/correct-records-displayed
branch
from
October 12, 2023 23:27
641c351
to
2b0dc9b
Compare
alukach
force-pushed
the
bugfix/555/correct-records-displayed
branch
from
October 13, 2023 21:09
34a06d0
to
c8bb72c
Compare
* Fix links to published-details * Rename column to better explain purpose (#587)
* Render draft action rather than approval log action * Simplify
…nto bugfix/555/correct-records-displayed
Tammo-Feldmann
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't add any more comments here since we already pair reviewed this. I like the changes that you made here.
…records-displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
canonical-redirect
view rather thanchange-update
view.canonical-redirect
,canonical-published-detail
, andcanonical-draft-edit
views to no longer take in a draft UUID (ie they only require the canonical UUID + action, such asv2/<str:model>/<uuid:canonical_uuid>/<edit|view|''>
).related_drafts(canonical_uuid: str)
andrelated_in_progress_drafts(canonical_uuid: str)
convenience methods to theChange
model queryset.CanonicalDraftEdit
view to render the latest in-progress draft (ie the draft with the loweststatus
value). In the event of no in-progress drafts, a404
is returned.Related to #555