Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct record linked from Campaign table #578

Merged

Conversation

alukach
Copy link
Member

@alukach alukach commented Oct 11, 2023

This PR makes the following changes:

  1. Ensures that link from the Campaign List table takes user to canonical-redirect view rather than change-update view.
  2. Updated the canonical-redirect, canonical-published-detail, and canonical-draft-edit views to no longer take in a draft UUID (ie they only require the canonical UUID + action, such as v2/<str:model>/<uuid:canonical_uuid>/<edit|view|''>).
  3. Add related_drafts(canonical_uuid: str) and related_in_progress_drafts(canonical_uuid: str) convenience methods to the Change model queryset.
  4. Strip down the logic of the CanonicalDraftEdit view to render the latest in-progress draft (ie the draft with the lowest status value). In the event of no in-progress drafts, a 404 is returned.

Related to #555

@alukach alukach force-pushed the bugfix/555/correct-records-displayed branch 2 times, most recently from bc930ae to 641c351 Compare October 12, 2023 23:26
@alukach alukach force-pushed the bugfix/555/correct-records-displayed branch from 641c351 to 2b0dc9b Compare October 12, 2023 23:27
@alukach alukach force-pushed the bugfix/555/correct-records-displayed branch from 34a06d0 to c8bb72c Compare October 13, 2023 21:09
@alukach alukach marked this pull request as ready for review October 13, 2023 22:26
* Fix links to published-details

* Rename column to better explain purpose (#587)
* Render draft action rather than approval log action

* Simplify
Copy link
Contributor

@Tammo-Feldmann Tammo-Feldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't add any more comments here since we already pair reviewed this. I like the changes that you made here.

@alukach alukach merged commit 535852c into feature/canonical-mi-workflow Oct 16, 2023
10 checks passed
@alukach alukach deleted the bugfix/555/correct-records-displayed branch October 16, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants