Clean up logic for header tabs #588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
reviewed
Oct 19, 2023
| has_progress_draft = ( | ||
| Change.objects.exclude(status=Change.Statuses.PUBLISHED) | ||
| .filter(Q(uuid=change.uuid) | Q(model_instance_uuid=change.uuid)) | ||
| has_published_draft = ( |
There was a problem hiding this comment.
Purely a style suggestion, but has_published_draft is an awful lot like has_progress_drafts.
Can we move those queries to be near eachother (ie either assigned to a variable up here or written inline in the returned dict)
There was a problem hiding this comment.
Sounds good to me. Made the change that you requested.
|
This work was merged elsewhere and we don't need this PR anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
I started this cleanup project when I ran into an issue with the object headers where published drafts where not showing up correctly. I refactored and simplified the logic around the arguments for the header tab.
Before
After