Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm unused get() method logic #589

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Rm unused get() method logic #589

merged 6 commits into from
Oct 20, 2023

Conversation

alukach
Copy link
Member

@alukach alukach commented Oct 19, 2023 •
edited
Loading

I think all of the logic within get() is unnecessary.

A 404 is thrown from get_object() if no IN_PROGRESS drafts are available, which is called in BaseUpdateView.get()

@alukach alukach requested a review from edkeeble October 19, 2023 19:29
@alukach
Copy link
Member Author

alukach commented Oct 19, 2023

I also just noticed that get_queryset() was on the class when it already has a queryset attribute. This should be removed.

@edkeeble edkeeble merged commit a975b70 into feature/canonical-mi-workflow Oct 20, 2023
10 checks passed
@edkeeble edkeeble deleted the fixup/rm-unused-method branch October 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edkeeble edkeeble edkeeble approved these changes

@Tammo-Feldmann Tammo-Feldmann Awaiting requested review from Tammo-Feldmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alukach @edkeeble @lint-action