-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy MI workflow changes to production #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support running e2e tests with playwright. Added login test to start. * Reorder playwright install step to after requirements are installed * Reset skip-string-normalization to true, to avoid making this PR a barrage of formatting changes with black. * Updated e2e test workflows. Added helper shell script to avoid remembering long docker-compose commands. * Move login to setUp fixture * Fill out campaign creation form * Add to campaign creation test * Add factories for dropdown options * Add E2E steps for IOP and CDPI * Add instrument and platform assertions * Add doi approval link * Update nav link for workflow * Add publication test * Complete e2e workflow * Update dois polling func * Clean up print statements * Loosen pytest version range * Add rabbitmq service * Save videos output * Rename job * Fix path * Add logging... * Lint * Update upload-artifact job * Save videos after tests Co-authored-by: Tammo Feldmann <[email protected]> Co-authored-by: Anthony Lukach <[email protected]>
…ified Display a link back to the parent campaign for related models
* Use canonical uuid in header tabs * Change has_progress_draft naming and placement * Add delete draft status * Remove doi approval view get_object method * Directly delete model without approval * Update model warning text * Create published delete drafts * Create working delete drafts * Removed duplicate requirement * Display back to campaign link for canonical views if model is related to Campaign model. * Added correct URL to related items from campaign view * Display View if related item is published or Edit if it is in progress on campaign detail view * Use snake case model name in header tab links * Use correctly formatted model name in Edit link URL from published detail view * Use canonical uuid in history links in tabs * Fix code style issues with Black * Updated to latest python 3.11 version in CI env * Create delete draft workflow * Add delete draft message * Fix typo in delete message * Unify model_name_for_url into a property on both Change and BaseModel classes. Remove condition in object_header_tabs and expand type hint to include BaseModel for the change variable. * Fix code style issues with Black * Enable running e2e tests locally with docker by making web container depend on rabbitmq * Support looking up and linking to a Campaign even in cases where there isn't yet a published Campaign or published related object (IOP, etc) * Removed print statement * Change historical detail view * Add condition for deleted models * Updated context variable to parent rather than campaign. Added condition to check for falseness of model_class prior to checking if it is a subclass of DeploymentChildMixin in order to avoid exception. * Fix code style issues with Black * Fix unnecessary f string * Removed TODO accidentally left in a template * Refactor is deleted checks * Update to latest python version in CI * Add rabbit mq as docker dependency * Restore object header tabs with uuid * Fix missing canonical id * Remove doi differences * Fix broken doi lookup --------- Co-authored-by: Edward Keeble <[email protected]> Co-authored-by: Lint Action <[email protected]>
Canonical Id workflow
…get proper back linking to campaign
template variable formatting Co-authored-by: Anthony Lukach <[email protected]>
Use canonical_uuid for canonical view links Co-authored-by: Anthony Lukach <[email protected]>
Co-authored-by: Anthony Lukach <[email protected]>
* Attempt to simplify parent link logic * Handle list view
… disabled fields to readonly
…e value of disabled fields
Preserve value of disabled fields when editing model forms
Bugfixes for Adding Related Objects to Deployment
Apache v2 license
Redirect to canonical_uuid after publishing rather than URL PK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.