Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle analysis tools #279

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Add bundle analysis tools #279

merged 5 commits into from
Apr 29, 2021

Conversation

AliceR
Copy link
Member

@AliceR AliceR commented Apr 26, 2021

Playing with some ideas to possibly eventually reduce bundle size and improve performance (#274).

The split between explore pages does not really improve the bundle size. I thought since mapbox-gl was a huge dependency, it could help to only add it to the one page where it is used. But the addition of two new pages makes up for the reduced node_modules size 😞 I might revert a093a82 and f4738eb if I don't learn how to better optimize these pages.

Before (on branch develop, using the project build):
Screenshot 2021-04-26 at 22 23 39

After (on this branch, using the project build):
Screenshot 2021-04-27 at 13 22 37

@AliceR AliceR requested a review from necoline April 26, 2021 20:12
Base automatically changed from tab-navigation to develop April 28, 2021 10:22
@AliceR
Copy link
Member Author

AliceR commented Apr 28, 2021

I removed the commits related to the refactoring of the explore page, and opened a separate PR for that conversation.

With that, this PR should be good to merge. Sure there be further ways for improvement. Integrating the bundle size information into the CI pipeline would be a nice to have. But adding the bundle analysis tools for local investigation is a good start.

@AliceR AliceR marked this pull request as ready for review April 28, 2021 13:59
@AliceR AliceR merged commit 4f2de7b into develop Apr 29, 2021
@AliceR AliceR deleted the performance branch April 29, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants