Quick Fixes for recent changes #373
Merged
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.sh. Ensure the API Gateway will redeploy (API Gateway deployment, not the main application deployment). Ensure the lambda execution role for the new lambda can actually call DynamoDB with ReadOnly Access. Added an extra line in the Lambda to verify the environment variable makes it through the deployment process. Added a call to the zip lambdas function for local deployment. #655
|
Sending changes to UAT now. Note: The nature of the environment that these changes affect is only in UAT and PROD, so I need to push this to UAT to do the actual feature / fix testing. Note: The smoke test passed in sandbox and I verified the new AWS Components were properly setup in Sandbox. I cannot do the integrated test until this is in UAT though (because there is no sandbox set up for the cross account cognito layer access token that this work depends on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Fixes for recent changes
Add a line in the terraspace deployment script to call to zip_lambdas.sh.
Ensure the API Gateway will redeploy (API Gateway deployment, not the main application deployment).
Ensure the lambda execution role for the new lambda can actually call DynamoDB with ReadOnly Access.
Added an extra line in the Lambda to verify the environment variable makes it through the deployment process.
Added a call to the zip lambdas function for local deployment.
Ticket Reference: https://github.com/NASA-IMPACT/csda-project/issues/655
Note: The nature of the environment that these changes affect is only in UAT and PROD, so I need to push this to UAT to do the actual feature / fix testing.
Note: The smoke test passed in sandbox and I verified the new AWS Components were properly setup in Sandbox. I cannot do the integrated test until this is in UAT though (because there is no sandbox set up for the cross account cognito layer access token that this work depends on)