Do not run tests a second time before deploying #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pushes to `develop` and `main` occur _only_ via PR merges, there's no need to run tests prior to deployment because the tests _must_ have already passed in order to permit PR merging. In this case, running tests again is redundant since they would be run again on identical code.
sharkinsspatial
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pushes to
developandmainoccur only via PR merges, there's no need to run tests prior to deployment because the tests must have already passed in order to permit PR merging. In this case, running tests again is redundant since they would be run again on identical code.This PR removes the deploy job from depending on the unit-tests and integration-tests jobs. This dependency previously prevented deployment from occurring because unit-tests and integration-tests were skipped on "push" to the develop and main branches. Thus, deployment to develop was skipped since its (now obsolete) dependencies were skipped.
The change in the PR was an oversight in the previous PR that prevented the tests from running redundantly on pushes.