Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of Additional OnlineAccess and OnlineResource. #304

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

binni979
Copy link
Contributor

@binni979 binni979 commented Oct 14, 2024

This is a pull request to solve this issue.

Description of the bug:
pyQuARC does not flag the OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description fields whenever a URL is not provided. When ARC makes their recommendations, we also make recommendations for the fields above, even if a URL is not initially provided. The issue seems to be noticed with ECHO-C collections.

Findings:
While working with the fields OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description, we were using the checks url_desc_presence_check and online_resource_type_presence_check. These checks are linked to a check_id called availability_check, which is designed to accept two arguments: field_value and parent_value.

However, when I debugged the code, I noticed that our function is actually receiving only one argument, field_value. The function one_item_presence_check correctly uses just this single argument. To resolve this mismatch, I updated the rule mapping by changing the check_id from availability_check to one_item_presence_check.

To Reproduce
Example concept ID: C1627523804-LARC (echo-c)

Now, the above fields errors are seen.
Screenshot 2024-10-13 at 8 52 11 PM

@binni979 binni979 requested a review from xhagrg October 14, 2024 01:55
@binni979 binni979 self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant