Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cmip6-tasmax-monthly-annual-max (no E&A capability) #131

Merged
merged 40 commits into from
Oct 7, 2024

Conversation

freitagb
Copy link

Why are you creating this Pull Request?

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for earth-information-center ready!

Name Link
🔨 Latest commit 261813a
🔍 Latest deploy log https://app.netlify.com/sites/earth-information-center/deploys/6704136a6e9d780008721079
😎 Deploy Preview https://deploy-preview-131--earth-information-center.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@freitagb freitagb changed the title NOT READY FOR MERGE - Create cmip6-tasmax-monthly-annual-max (no E&A capability) Create cmip6-tasmax-monthly-annual-max (no E&A capability) Oct 4, 2024
merge SLR with dataset landing page
j08lue
j08lue previously requested changes Oct 5, 2024
Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new dataset:

https://deploy-preview-131--earth-information-center.netlify.app/data-catalog/cmip6-climdex-tasmax-yearly-median

Made a few copy edits.

Looks good in terms of functionality.

There are a few unrelated changes in this PR. Perhaps this needs to be rebased to a more recent develop or so?

datasets/cmip6-tasmax-monthly-annual-max.data.mdx Outdated Show resolved Hide resolved
datasets/cmip6-tasmax-monthly-annual-max.data.mdx Outdated Show resolved Hide resolved
datasets/cmip6-tasmax-monthly-annual-max.data.mdx Outdated Show resolved Hide resolved
datasets/cmip6-tasmax-monthly-annual-max.data.mdx Outdated Show resolved Hide resolved
@freitagb freitagb requested review from j08lue and agurvich and removed request for j08lue October 7, 2024 21:50
@agurvich agurvich dismissed j08lue’s stale review October 7, 2024 21:52

outdated -freitagb

@agurvich agurvich merged commit 1514e67 into develop Oct 7, 2024
6 checks passed
@agurvich agurvich deleted the add-tasmax-dataset branch October 7, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants