-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove tagline from GHGC #155
Conversation
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
A couple of notes for when you review this PR @dzole0311 @amarouane-ABDELHAK @j08lue Currently the carousel doesn't support text on background images so the text is baked onto the images themselves. This PR removes the GHGC tagline in the carousel as Deborah requested Other changes in this PR include renaming of sea level rise to sea level change throughout the Earth.gov site as was requested by Nadya at HQ. I believe I've caught all of them but let me know if any were missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and all the renamed Sea Level Change resources seem to work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well!
Currently the carousel doesn't support text on background images so the text is baked onto the images themselves
@freitagb I created a quick showcase to test adding text dynamically over the images. It’s definitely doable with a few tweaks if this is something we want (though I believe the original intention was to avoid overlaying text directly on the images like traditional carousels)
Demo: https://deploy-preview-156--earth-information-center.netlify.app/
Changes: https://github.com/NASA-IMPACT/veda-config-eic/pull/156/files
Why are you creating this Pull Request?