Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tagline from GHGC #155

Merged
merged 6 commits into from
Nov 22, 2024
Merged

remove tagline from GHGC #155

merged 6 commits into from
Nov 22, 2024

Conversation

freitagb
Copy link

Why are you creating this Pull Request?

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for earth-information-center ready!

Name Link
🔨 Latest commit 29c2fd8
🔍 Latest deploy log https://app.netlify.com/sites/earth-information-center/deploys/673e63f08ba1760008a98074
😎 Deploy Preview https://deploy-preview-155--earth-information-center.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@freitagb
Copy link
Author

A couple of notes for when you review this PR @dzole0311 @amarouane-ABDELHAK @j08lue

Currently the carousel doesn't support text on background images so the text is baked onto the images themselves. This PR removes the GHGC tagline in the carousel as Deborah requested

Other changes in this PR include renaming of sea level rise to sea level change throughout the Earth.gov site as was requested by Nadya at HQ. I believe I've caught all of them but let me know if any were missed.

Copy link

@amarouane-ABDELHAK amarouane-ABDELHAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and all the renamed Sea Level Change resources seem to work as expected.

Copy link

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

Currently the carousel doesn't support text on background images so the text is baked onto the images themselves

@freitagb I created a quick showcase to test adding text dynamically over the images. It’s definitely doable with a few tweaks if this is something we want (though I believe the original intention was to avoid overlaying text directly on the images like traditional carousels)

Demo: https://deploy-preview-156--earth-information-center.netlify.app/
Changes: https://github.com/NASA-IMPACT/veda-config-eic/pull/156/files

@freitagb freitagb merged commit dc11b20 into develop Nov 22, 2024
6 checks passed
@freitagb freitagb deleted the update-ghg-image branch November 22, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants