-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove veda-config related steps #181
fix: remove veda-config related steps #181
Conversation
@smohiudd @anayeaye thoughts on creating a new directory just to test these changes?
I was also thinking of using |
Workflow StatusStarting workflow... View action run Collection Publication Status
|
I'm ok with creating a temporary test directory |
|
||
jobs: | ||
dataset-publication-and-configuration: | ||
permissions: | ||
pull-requests: write | ||
contents: read | ||
runs-on: ubuntu-latest | ||
environment: staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hardcoded for now to use the staging
environment variable I defined in this github repo
.github/workflows/pr.yml
Outdated
response=$(curl -X POST \ | ||
${{ vars.STAGING_COGNITO_DOMAIN }}/oauth2/token \ | ||
-H "Content-Type: application/x-www-form-urlencoded" \ | ||
-d "grant_type=client_credentials" \ | ||
-d "client_id=${{ vars.STAGING_CLIENT_ID }}" \ | ||
-d "client_secret=${{ secrets.STAGING_CLIENT_SECRET }}" | ||
-d "client_secret=${{ vars.STAGING_CLIENT_SECRET }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be stored in the environment secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using a secret in this case would be appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
branches: ['main', 'feat/automated-staging-publish'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches: ['main', 'feat/automated-staging-publish'] | |
branches: ['main'] |
I can remove this later but I added it to prove that it can be triggered on pushes to a branch
The action originally looked at all changed files in the dataset directory. Can we look at only the added files so we're only triggering new. Looks like tj-actions can find added files as well: |
Closing this in place of this work #185 |
#180
Testing
I used a valid collection to test this workflow and I updated the trigger to trigger on any pushes to this current branch but can change that later 😅