Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove veda-config related steps #181

Conversation

botanical
Copy link
Member

@botanical botanical commented Oct 31, 2024

#180

Testing

I used a valid collection to test this workflow and I updated the trigger to trigger on any pushes to this current branch but can change that later 😅

@botanical
Copy link
Member Author

@smohiudd @anayeaye thoughts on creating a new directory just to test these changes?

      - ingestion-data/testing/dataset-config/*

I was also thinking of using bangladesh-landcover-2001-2020 collection to test this and I added a test.json to this PR in the directory above. I think if we merge this into Slesa's original PR, then it might trigger a test run?

@botanical botanical marked this pull request as ready for review November 4, 2024 21:46
Copy link

github-actions bot commented Nov 5, 2024

Workflow Status

Starting workflow... View action run

Collection Publication Status

  • hls-swir-falsecolor-composite-TEST: Successfully published ✅

@smohiudd
Copy link
Contributor

smohiudd commented Nov 5, 2024

I'm ok with creating a temporary test directory


jobs:
dataset-publication-and-configuration:
permissions:
pull-requests: write
contents: read
runs-on: ubuntu-latest
environment: staging
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hardcoded for now to use the staging environment variable I defined in this github repo

response=$(curl -X POST \
${{ vars.STAGING_COGNITO_DOMAIN }}/oauth2/token \
-H "Content-Type: application/x-www-form-urlencoded" \
-d "grant_type=client_credentials" \
-d "client_id=${{ vars.STAGING_CLIENT_ID }}" \
-d "client_secret=${{ secrets.STAGING_CLIENT_SECRET }}"
-d "client_secret=${{ vars.STAGING_CLIENT_SECRET }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be stored in the environment secret?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a secret in this case would be appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@botanical botanical changed the title fix: comment out veda-config related steps fix: remove veda-config related steps Nov 5, 2024
@botanical botanical requested review from smohiudd and removed request for anayeaye and smohiudd November 8, 2024 22:49

on:
pull_request:
branches:
- main
branches: ['main', 'feat/automated-staging-publish']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: ['main', 'feat/automated-staging-publish']
branches: ['main']

I can remove this later but I added it to prove that it can be triggered on pushes to a branch

@smohiudd
Copy link
Contributor

smohiudd commented Nov 13, 2024

The action originally looked at all changed files in the dataset directory. Can we look at only the added files so we're only triggering new. Looks like tj-actions can find added files as well:

@botanical
Copy link
Member Author

Closing this in place of this work #185

@botanical botanical closed this Nov 20, 2024
@botanical botanical deleted the feat/remove-veda-config-pr-creation branch November 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants