Fix contextual link for taxonomy pills

Fix #627
NASA-IMPACT · Aug 22, 2023 · 1653d23 · 1653d23
1 parent 889dd91
commit 1653d23
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/app/scripts/components/common/content-taxonomy.tsx b/app/scripts/components/common/content-taxonomy.tsx
@@ -9,7 +9,6 @@ import { Actions } from './browse-controls/use-browse-controls';
 
 import { variableGlsp } from '$styles/variable-utils';
 import { Pill } from '$styles/pill';
-import { DATASETS_PATH } from '$utils/routes';
 
 const TaxonomySection = styled.section`
   grid-column: 1 / -1;
@@ -36,10 +35,11 @@ const TaxonomyList = styled.dl`
 
 interface ContentTaxonomyProps {
   taxonomy: Taxonomy[];
+  linkBase: string;
 }
 
 export function ContentTaxonomy(props: ContentTaxonomyProps) {
-  const { taxonomy } = props;
+  const { taxonomy, linkBase } = props;
 
   if (!taxonomy.length) return null;
 
@@ -60,9 +60,9 @@ export function ContentTaxonomy(props: ContentTaxonomyProps) {
                   variation='achromic'
                   key={t.id}
                   as={Link}
-                  to={`${DATASETS_PATH}?${
-                    Actions.TAXONOMY
-                  }=${encodeURIComponent(JSON.stringify({ [name]: t.id }))}`}
+                  to={`${linkBase}?${Actions.TAXONOMY}=${encodeURIComponent(
+                    JSON.stringify({ [name]: t.id })
+                  )}`}
                 >
                   {t.name}
                 </Pill>

diff --git a/app/scripts/components/datasets/s-overview/index.tsx b/app/scripts/components/datasets/s-overview/index.tsx
@@ -75,7 +75,7 @@ function DatasetsOverview() {
           )}
           renderDetailsBlock={() => (
             <>
-              <ContentTaxonomy taxonomy={taxonomies} />
+              <ContentTaxonomy taxonomy={taxonomies} linkBase={DATASETS_PATH} />
               <DatasetClassification dataset={dataset.data} />
             </>
           )}

diff --git a/app/scripts/components/stories/single/index.tsx b/app/scripts/components/stories/single/index.tsx
@@ -45,7 +45,7 @@ function StoriesSingle() {
             attributionAuthor={media?.author?.name}
             attributionUrl={media?.author?.url}
             renderDetailsBlock={() => (
-              <ContentTaxonomy taxonomy={story.data.taxonomy} />
+              <ContentTaxonomy taxonomy={story.data.taxonomy} linkBase={STORIES_PATH} />
             )}
           />