on how to run the tests

make steps appear in report, use better locators and validators, add expectations verbose, ...

This reverts commit 233a31c, reversing
changes made to 46e1c5d.

…mpty (#1218)

**Related Ticket:** #1028 

### Description of Changes
- It turns out that there are datasets (such as globalscope bluetarp)
that should not have any titiler parameters.
Bluetarp data from stac backend:
https://staging.openveda.cloud/api/stac/collections/blue-tarp-planetscope

### Notes & Questions About Changes
This makes me wonder about if we can validate anything about render
parameters - ex. When there is no render parameter at all from stac
back-end points, is there any way to be sure that this dataset is meant
to be without render parameters ? - Tagging @smohiudd for this question.

### Testing
Test this branch with veda-config's globalscope bluetarp dataset.

You can find VEDA Dashboard preview link to test these changes:
NASA-IMPACT/veda-config#470

## 🎉 Features
- Cookie consent component:
#1163,
#1165,
#1127,
#1177
- Stories Hub export in #1162
- Expose As Is - PageHeader, LinkElement Prop & Logo in
#1184
## 🚀 Improvements

- Add docs for registry dev in
#1169
- Timeline date selection centering functionality in
#1181
- Deprecate old explore page, Mapbox component
#1176
- Update doc with new diagrams about general architecture in
#1195
-  Add playwright in #1139
- Pre-select AOIs that have the "selected" prop set to true in
#1215
- 
## 🐛 Fixes
- Check dastaset analysis exclude attribute before running analysis in
#1175
- Restrict dynamic colormaps to applicable layer types in
#1183
- Fix external link badge display for tools hosted under the same domain
in #1192
- Escape special characters in regex expression when searching datasets
in #1204


### New Contributors
* @snmln made their first contribution in
#1127
* @AliceR made their first contribution in
#1204

**Related Ticket:** _{link related ticket here}_

### Description of Changes
We want to run the github playwright step only on branches whose name
start with `release`.

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
_{Update with info on what can be manually validated in the Deploy
Preview link for example "Validate style updates to selection modal do
NOT affect cards"}_

in .prettierrc. Also, added the typescript parser as override for .ts/.tsx files, which finally enabled me to correctly lint the typescript files.

just a one line change to the style guide docs

Enable prettier for .ts/.tsx files, but only warn. Also, keep prettier rules in a single location in .prettierrc, and add the typescript parser as override for .ts/.tsx files, which finally enabled me to correctly lint the typescript files.

**Related Ticket:** #1207

### Description of Changes
So far, added a first test for the scenario "User selects a pre-defined
AOI". I'm adding some `data-testid` properties to relevant dom elements
in order to select them in the test.

Also, added some documentation on how to run the tests. @hanbyul-here if
you want to try that on your machine, and let me know if it works?

### Notes & Questions About Changes
more tests to be added

### Validation / Testing
Follow the instructions added to the SETUP.md guide to run the tests
locally. See if they pass!

This pr fixes infinite rerendering issue (it was from the parsing error
of cookie value - so I added a unit test to make sure this works. - I
used the solution from this post, feel free to edit if you see any
improvement
https://stackoverflow.com/questions/5142337/read-a-javascript-cookie-by-name)
- also feel free to edit the test, I mainly put it for my dev purpose.

I removed currenwindowurl logic, replaced it with pathname passed from
the layout root. I started making this change and then realized that
this is not the cause of infinite rendering problem, but I think it is
probably safer to depend on the pathname change than location.href since
href can include so many things like query parameters?

**Related Ticket:** _{link related ticket here}_

### Description of Changes
This update addresses a mistake I made from the initial fix involving
the new `isExternalLink` prop, which unintentionally altered the
behavior of external links. Basically, this prop not only hid the
"External Link" badge but also incorrectly routed external links through
React's internal routing, resulting in URLs like
`earth.gov/visit/https://earth.gov/mobile-climate-mapper` instead of
correctly navigating to `earth.gov/mobile-climate-mapper`

**What's fixed here:**

1. Removed the `isExternalLink` prop to revert unintended internal link
behavior
2. Introduced a new prop, `hideExternalLinkBadge` that more clearly
describes it's role and is used specifically for **visually hiding** the
"External Link" badge without altering the link's external behavior

### Notes & Questions About Changes

To minimize team effort for a hotfix release and since this fix is
specific to the EIC instance only, I did the following:

1. Created a branch from the latest tag specifically for this hotfix
2. Bumped the EIC instance to the latest UI version using this hotfix
branch
3. Protected the hotfix branch, which will remain in place until the
next planned release (in two weeks)

### Validation / Testing
1. Use the `hideExternalLinkBadge` prop to the `External Link Test`
story
2. Check that the "External Link" badge is hidden from the story card
3. Check that the link is opened correctly once the card is clicked

Or check it out in [practice on the EIC instance
here](https://deploy-preview-144--earth-information-center.netlify.app/visit),
where the Mobile Climate Mapper card has no "External Link" badge
anymore:

**Related Ticket:**
US-GHG-Center/ghgc-architecture#391

### Description of Changes

With this change the data catalog filters controls are initially
displayed in a closed state when the page loads.

### Notes & Questions About Changes

This affects two pages: Data Catalog and Exploration.

### Validation / Testing

Visit the following URLs (on localhost), all of them should display the
filter controls closed on page load:

- [Data Catalog page, no filter option
selected](http://localhost:9000/data-catalog)
- [Data Catalog page, filter options are
selected](http://localhost:9000/data-catalog?taxonomy=%7B%22Topics%22%3A%5B%22burn-severity%22%5D%2C%22Source%22%3A%5B%22cmip-6%22%2C%22epa%22%5D%7D)
- [Exploration page, no filter option
selected](http://localhost:9000/exploration)
- [Exploration page, a filter option is
selected](http://localhost:9000/exploration?datasets=%5B%5D&taxonomy=%7B%22Topics%22%3A%5B%22climate-model%22%5D%7D)

First of all, I apologize that I could not make this suggestion as a
part of review. It is still challenging for me to make a suggestion
without actually touching the code.

This PR handles several things. The first to fix is cookieconsent form
gradually disappears on the first page load. The second is not depending
on session storage - mainly because I feel like it was diverging the
logic flow - but if I am missing anything, please feel free to close
this. The third is moving out the utility function outside of the
component, so it doesn't have to be declared as a dependency of
useEffect hook.

**Related Ticket:**
#1171

### Description of Changes

- Relocating cookie retrieval, validation, and creation functionality
from `layoutRoot` to `cookieConsentForm`
- Implementing `session item` to track when a session has begun for each
individual user and only run validation and retrieval functionality on
session start and when a response has not been recorded.
- Adjusting Banner content to accept markdown in config props.  

### Notes & Questions About Changes

### Validation / Testing
Clear out all cookies in your local machine to do so: open `dev tools`
-> navigate to `application tab`-> navigate to `cookies` in the left
panel -> right click `clear`
- After clearing your existing site cookies, navigate to any page. Click
on **Decline**. Navigate to another page and you should not see the
cookie consent form component.
- Clearing your existing site cookies again, navigate to any page. Click
on **Accept**. Navigate to another page and you should not see the
cookie consent form component.
- Clearing your existing site cookies again, navigate to any page. Click
on **X**. Navigate to another page and you should see the cookie consent
form component rerendered.

…he hero

)

**Related Ticket:** #1186
**Related PR:** developmentseed/next-veda-ui#10

**Note**
To expose interfaces from veda-ui - they should be defined in `.ts`
files vs `.d.ts` files. This is because parcel isn't building the
typescript definition files into `lib/index.d.ts` but does so when the
file is `.ts`.

**When building the library with `.d.ts` extension - there are NO type
hints from NextInstance side**
<img width="1086" alt="Screenshot 2024-11-04 at 9 23 19 AM"
src="https://github.com/user-attachments/assets/75d746c3-018e-44a8-8ee3-4f37e336c363">

**When building the library with `.ts` extension - there are type hints
form NextInstance side**
<img width="1124" alt="Screenshot 2024-11-04 at 9 20 02 AM"
src="https://github.com/user-attachments/assets/26ec377d-feb1-48ca-a18b-e54835de91ff">


### Description of Changes
* Update typescript definition file of nav types to typescript file
* Add declaration true to tsconfig

### Notes & Questions About Changes
Found this thread about typescript definition files and parcel build
here parcel-bundler/parcel#1240

### Validation / Testing
_{Update with info on what can be manually validated in the Deploy
Preview link for example "Validate style updates to selection modal do
NOT affect cards"}_

**Related Ticket:**
US-GHG-Center/veda-config-ghg#636

### Description of Changes

1. Introduced new `cardDescription` and `cardMedia` props to enable
customizable card content
2. Implemented a fallback background color for cases where no media (e.g
image source) is provided

These updates are applied across various places where the card component
is used (story cards) but also layer cards in the Data Catalog and the
E&A Catalog to better control displayed descriptions and images.

### Notes & Questions About Changes

### Validation / Testing

1. Add `cardDescription` to the 'This is the life of water' story in the
MDX configuration file
2. Verify that `/stories` displays the newly added `cardDescription` on
the card
3. Click on the story -> verify that the hero section retains its
previous description, separate from the card description
4. Try the same with `cardMedia`
5. Also try to remove both the `cardMedia` and the `media` prop ->
verify that there's a fallback background color shown

Verify that the behavior below (copied from the issues' acceptance
criteria) is applied:

1. Story and dataset administrators can define a hero image and a card
image separately from one another, within the mdx file
2. Story and dataset administrators can define a hero description and a
card description separately from one another, within the mdx file
3. If a story or dataset does not have any hero or card images
configured, then we default to a blank space of a solid primary color
(like the blue hero for Data Catalog in GHGC)
4. If a story or dataset has a hero image defined, but no card image
defined, then the card image shows the hero image (like how it currently
functions)

… library, and get to render in nextJs instance

…trol

… have externallinkbadge hotfix changes

## 🎉 Features
* Card image/description independent of hero image/description by
@dzole0311 in #1244

## 🚀 Improvements
* Cookie consent code cleanup by @snmln in
#1199 , and @hanbyul-here in
#1240 , and @hanbyul-here in
#1241
* Add ADR about design system change by @j08lue in
#890
* Update condition to run playwright tests on release branches by
@dzole0311 in #1228
* Update STYLE_GUIDE.md by @AliceR in
#1227
* Fix lint configuration by @AliceR in
#1219
* Add tests for the AOI feature specification by @AliceR in
#1216
* Set data catalog filters to be closed by default by @vgeorge in
#1243
* Update tsconfig and make nav interfaces exposable for consumption by
@sandrahoang686 in #1223

## 🐛 Fixes
* Hotfix to hide the external link badge from cards by @dzole0311 in
#1231

## New Contributors
* @vgeorge made their first contribution in
#1243

**Full Changelog**:
v5.9.0...v5.10.0

**Related Ticket:** #1154

### Description of Changes
* Fixed to have changes from
https://github.com/NASA-IMPACT/veda-ui/pull/1231/files# which I
accidentally removed when resolving conflicts in main feature branch
* Remove `onClick` from `LinkProperties`
* When something is a link, it doesn't need an onClick event... The
onClick event should be placed on the `Card` Component instead of link
props
* LinkProperties should not be required for the card component. Only
when the card re-routes would it need the linkProperties. For example,
cards on the dataset selector modal dont re-route and we shouldn't have
to pass in linkProps
* Remove try/catch around aoi area/point selection logic and into local
state with useEffect

### Note
Built `v5.9.1-ea.0` off of these changes
Update: Bulit `v5.9.1-ea.1` has been built

### Validation / Testing
* Please make sure Dataset Layer Selection modal and E&A works as
expected
* Please make sure all cards in the dashboard are working as expected
* Make sure external cards link externally and have the external badge
   * Make sure internal cards link internally correctly
   * Make sure Dataset Layer Selection modal selects cards as expected

**NextJs Preview with updated version:**
developmentseed/next-veda-ui#4

**Related Ticket:** #902

### Description of Changes
**Related NextJs PR/Branch:**
developmentseed/next-veda-ui#4

**GHG Preview** with this branch pulled in generated here =>
US-GHG-Center/veda-config-ghg#659

**Iteration 1** - Issue
#902, changes by
@sandrahoang686
* Exposed `ExplorationAndAnalysis` component
* Exposed `timelineDatasetsAtom` to be used NextJs side
* Exposed & Moved/decoupled `DatasetSelectorModal` out of
`ExplorationAndAnalysis`. ExplorationAndAnalysis only needs to know the
dataset layers to be displayed. DatasetSelectorModal or whatever layer
selection method should be controlled at the parent level above
`ExplorationAndAnalysis`.
* Commented out certain controls that were breaking
`ExplorationAndAnalysis` in NextJs instance
   * `AnalysisMessageControl`
   * `CustomAoIControl`

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
* Validate that Datalayer Selection Modal works as expected
* Validate that E&A features work as expected - aois, analyzation,
adding/removing cards
* Validate that all card linking works as expected