-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to data browser + prefix in dataset overview page #617
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@danielfdsilva @hanbyul-here can you help make this better? |
@slesaad Yeah, we will take it from here. Thanks for working on poc! |
After some internal discussion we agreed that adding another button to the dataset header is detrimental to the user experience. We recommend to use the "Analyse data" modal to link to external sources and/or having a direct link in the dataset page content. We will set this up as an example and change the "analyse data" button label to better reflect the new modal nature. cc @hanbyul-here |
@danielfdsilva @hanbyul-here let's hold this off for now, we showed a demo of this new feature, and it looks like we might need to make some changes. i think the external url will still hold, but how we do it might change. |
defe45a
to
42840f1
Compare
42840f1
to
8bed731
Compare
I went ahead and made the link to data browser as a part of 'Access Data' Modal. I updated this pr on veda ghg accordingly: https://github.com/NASA-IMPACT/veda-config-ghg/pull/41/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo
Description
download
button to the dataset overview page that links to the data browser > /path-to-collection/Demo
https://deploy-preview-41--ghg-demo.netlify.app/data-catalog/land-atmoshphere-co2-emissions-monthly-2022