Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to data browser + prefix in dataset overview page #617

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Aug 14, 2023

Description

  • Add a download button to the dataset overview page that links to the data browser > /path-to-collection/

Demo

https://deploy-preview-41--ghg-demo.netlify.app/data-catalog/land-atmoshphere-co2-emissions-monthly-2022

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 64f90cd
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/64efa256114f9b000830f9b1
😎 Deploy Preview https://deploy-preview-617--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad
Copy link
Member Author

slesaad commented Aug 16, 2023

@danielfdsilva @hanbyul-here can you help make this better?

@hanbyul-here
Copy link
Collaborator

@slesaad Yeah, we will take it from here. Thanks for working on poc!

@danielfdsilva
Copy link
Collaborator

After some internal discussion we agreed that adding another button to the dataset header is detrimental to the user experience. We recommend to use the "Analyse data" modal to link to external sources and/or having a direct link in the dataset page content.

We will set this up as an example and change the "analyse data" button label to better reflect the new modal nature. cc @hanbyul-here

@slesaad
Copy link
Member Author

slesaad commented Aug 22, 2023

@danielfdsilva @hanbyul-here let's hold this off for now, we showed a demo of this new feature, and it looks like we might need to make some changes. i think the external url will still hold, but how we do it might change.

@hanbyul-here
Copy link
Collaborator

I went ahead and made the link to data browser as a part of 'Access Data' Modal. I updated this pr on veda ghg accordingly: https://github.com/NASA-IMPACT/veda-config-ghg/pull/41/files

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo

mock/datasets/no2.data.mdx Outdated Show resolved Hide resolved
@j08lue j08lue self-requested a review August 30, 2023 20:11
@hanbyul-here hanbyul-here merged commit 9367bb3 into main Aug 30, 2023
8 checks passed
@hanbyul-here hanbyul-here deleted the add-download branch August 30, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants