Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstrings for plotting_functions.py #252

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

brianpm
Copy link
Collaborator

@brianpm brianpm commented Aug 3, 2023

This PR is only for improved documentation of plotting_functions.py.

It modifies all docstrings in the module.

Docstrings follow Numpy conventions: https://numpydoc.readthedocs.io/en/latest/format.html

I think I got everything. A few of them don't have as much info, but I think I pretty fully described the functions that users who will be trying to plug in their own scripts would need to see.

Literally this just changes the docstrings, so I didn't do any testing because no code is altered.

@brianpm
Copy link
Collaborator Author

brianpm commented Sep 2, 2023

Added docstrings for global_latlon_map

@nusbaume nusbaume self-requested a review October 3, 2023 19:17
@nusbaume nusbaume added the documentation Improvements or additions to documentation label Oct 3, 2023
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Just found some minor typos.

lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
lib/plotting_functions.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@nusbaume nusbaume merged commit 1c87fd4 into NCAR:main Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants