Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tape Recorder plots for Q #268

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

justin-richling
Copy link
Collaborator

@justin-richling justin-richling commented Nov 14, 2023

This will add the diagnostic "tape recorder" plot of Q to the Special plots section of the ADF.

The tape recorder plot will highlight moisture in the vertical vs monthly averaged mean on the x-axis for the tropical band between 10S and 10N. The default plot will be case/baseline vs MLS and ERA5 data:

Q_tape_recorder_FCLTHIST_vs_FLTHIST_2000_2011

If the ADF is comparing against Obs, the tape recorder will only plot the test case vs the default MLS and ERA5 data.

TapeRecorder_ANN_Special_Mean_OBS

This PR will also add some CSS code to block and grey out any seasonal tab not available for plots on the website.
Screen Shot 2023-11-14 at 11 47 26 AM

Closes #266

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but I did have some (hopefully) minor change requests. Also it would be helpful to double check all of the import statements in tape_recorder.py, as I feel like a lot of them were duplicates and thus weren't needed.

scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
This cleans up a lot of repeated code and documentations.

This also fixes issues with CESM time coords.
@justin-richling
Copy link
Collaborator Author

justin-richling commented Dec 29, 2023

@nusbaume I think I got all the suggestions, thanks for taking a look and catching some of these. If you wouldn't mind taking another quick look.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better! Just a few last additional change requests.

scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Outdated Show resolved Hide resolved
scripts/plotting/tape_recorder.py Show resolved Hide resolved
Prints if debug is enabled when running the ADF
@justin-richling
Copy link
Collaborator Author

justin-richling commented Jan 3, 2024

@nusbaume I took care of the last suggestions, it should be good, hopefully, for a final look over. Thanks.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just one last new change.

Comment on lines 74 to 75
#Continue to next iteration:
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will result in the QBO amplitude file being skipped as well, even if it doesn't exist. Maybe to be safe I would return to the original version, but with a debug_log statement that includes both plot_loc_ts and plot_loc_amp.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set, thanks for the insight.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks for dealing with all of my requests!

Bring in changes from PR NCAR#240
@justin-richling justin-richling merged commit 656e406 into NCAR:main Jan 9, 2024
7 checks passed
@justin-richling justin-richling deleted the tape_recorder branch January 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tape Recorder for Q to Plots
2 participants