-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tape Recorder plots for Q #268
Conversation
Also update web pages to lock out seasons on plot pages that don't apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, but I did have some (hopefully) minor change requests. Also it would be helpful to double check all of the import
statements in tape_recorder.py
, as I feel like a lot of them were duplicates and thus weren't needed.
This cleans up a lot of repeated code and documentations. This also fixes issues with CESM time coords.
@nusbaume I think I got all the suggestions, thanks for taking a look and catching some of these. If you wouldn't mind taking another quick look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better! Just a few last additional change requests.
Prints if debug is enabled when running the ADF
@nusbaume I took care of the last suggestions, it should be good, hopefully, for a final look over. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just one last new change.
scripts/plotting/qbo.py
Outdated
#Continue to next iteration: | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will result in the QBO amplitude file being skipped as well, even if it doesn't exist. Maybe to be safe I would return to the original version, but with a debug_log
statement that includes both plot_loc_ts
and plot_loc_amp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set, thanks for the insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks for dealing with all of my requests!
Bring in changes from PR NCAR#240
This will add the diagnostic "tape recorder" plot of Q to the Special plots section of the ADF.
The tape recorder plot will highlight moisture in the vertical vs monthly averaged mean on the x-axis for the tropical band between 10S and 10N. The default plot will be case/baseline vs MLS and ERA5 data:
If the ADF is comparing against Obs, the tape recorder will only plot the test case vs the default MLS and ERA5 data.
This PR will also add some CSS code to block and grey out any seasonal tab not available for plots on the website.
Closes #266