Update TEM configuration #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move each TEM configuration into case and baseline sections of config file
nusbaume
requested changes
Jan 30, 2024
|
@nusbaume I think I addressed your comments/suggestions. Thanks for looking this over, the changes are in when you get a chance to review it again. Thanks! |
nusbaume
requested changes
Jan 31, 2024
|
@nusbaume There was also a bug for the TEM plots if the file exists and redo plot is false, it created an empty plot and saved that to the web. I've tested this with model vs model and model vs obs. If you don't mind just looking at these two changes again that'd be great. |
nusbaume
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like it might make more sense to move the TEM configuration into the case subsections as requested by @cecilehannay.
This will move each TEM configuration into case and baseline sections of config file and will update the TEM files to account for the configuration change.