Cam fv small fixes #529
Merged
Cam fv small fixes #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdraeder
added
Good First Issue
|
Hi @kdraeder These fixes look good, but you have some merges from various branches in the commits. |
|
Do you have much lined up for your office hours?
Other times can work too.
Thanks!
Kevin
…On Thu, Aug 17, 2023 at 7:02 AM Helen Kershaw ***@***.***> wrote:
Hi @kdraeder <https://github.com/kdraeder> These fixes look good, but you
have some merges from various branches in the commits.
Do you have half and hour or so to meet and we can fix your git history?
—
Reply to this email directly, view it on GitHub
<#529 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFFGEAOQLOZ35UBIRKPXJDXVYI5BANCNFSM6AAAAAA3STCIVE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
not yet! swing on by this afternoon. |
shell_scripts/cesm2_1/
assimilate.csh.template
Avoid listing files if the CAM_PHIS file already exists.
setup_advanced
setup_hybrid
Define a TMPDIR that's not the default /var/tmp.
Changing CIME_OUTPUT_ROOT changes RUNDIR, so define RUNDIR after
CIME_OUTPUT_ROOT.
Check for existence of inflation files.
kdraeder
force-pushed
the
cam-fv_small_fixes
branch
from
18edc9f
to
8c29b61
Compare
|
@hkershaw-brown maybe bundle with fix for #530 |
|
Whatever's convenient for you. None of these are holding me back.
…On Fri, Aug 18, 2023 at 7:57 AM Helen Kershaw ***@***.***> wrote:
@hkershaw-brown <https://github.com/hkershaw-brown> maybe bundle with fix
for #530 <#530>
—
Reply to this email directly, view it on GitHub
<#529 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFFGEF2TXKBD2RYPJNLADLXV5YDVANCNFSM6AAAAAA3STCIVE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Several small independent upgrades to cam-fv shell scripts, that have accumulated over the past months and should be committed before further work in my clone. They address the definition of a temp directory, checking the existence of inflation files, and defining RUNDIR at the right place.
Fixes issue
None
Types of changes
Documentation changes needed?
None
Tests
I ran the setup scripts and they set up cases correctly.
Checklist for merging
Checklist for release
Testing Datasets
"Dataset" = all of the files needed to set up a cam-fv assimilation; too many to list here.