-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding diagnostics to WRF-DART documentation #544
Conversation
note for reviewers, the readthedocs for this pull request can be viewed can be viewed here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@braczka this documentation is great. I have a few questions and comments, but overall this could be merged now. Let me know what you think about the following comments and I can go ahead and approve this PR.
It might be useful here to include a link to our documentation page that details the other QC values and their reason for rejection.
"See the 'DART quality control field page' (https://docs.dart.ucar.edu/en/latest/guide/dart-quality-control.html) for more information on the other values for QC and their reason for rejection"
This is more of a question I have personally, but what determines the vertical axis for the different plots? Most of the diagnostic plots use pressure, but this plot uses surface. Is it simply the type of observation and what that type uses as a vertical coordinate that determines this?
In the Quantification of model-observation mismatch and ensemble spread section of the diagnostics, the ensemble statistic total spread is used explicitly (copy = 'totalspread';). Are there other useful ensemble statistics other than total spread that could used for these plot_rmse figures and should be mentioned here?
It may be useful here to give some examples of these modifiable pre-set options.
Only pinned sphinx and sphinx_rtd_theme. May want to revist this and pin everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approved.
Description:
Added a more complete diagnostics section to the WRF-DART Tutorial.
Fixes issue
Address issue #543
Types of changes
Documentation changes needed?
Tests
I used diagnostic output from a WRF Tutorial example I have already run. The
BASEDIR is located here: /glade/scratch/bmraczka/WRF_DART_Tut4. The analysis_increment.nc,
obs_epoch_029.nc and obs_diag_output.nc files, in which I tested the new diagnostic section with
are located in ~/output/2017042712/.
Checklist for merging
Checklist for release
Testing Datasets