Quickbuild mpif08 #562

hkershaw-brown · 2023-10-23T19:05:40Z

Description:

Added an mpif08 option to quickbuild.sh for model quickbuilds.

I've added mpi as an option for the 1st argument to quickbuild.sh. This is because it seemed likely that someone might specify ./quickbuild.sh mpi if they can do ./quickbuild.sh mpif08

The default is still mpi.

The GSI converter uses mpi, but its own mpi calls (not mpif08)
https://github.com/NCAR/DART/blob/main/observations/obs_converters/GSI2DART/mpisetup.f90
I have left this alone for now.

Fixes issue

Fixes #261, fixes #551, fixes #497

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Documentation changes needed?

My change requires a change to the documentation.
- I have updated the documentation accordingly.
  added the fix for Documentation needs more information about the "quickbuild nompi" option #497 in this pull request.

Tests

Building, with mpi, mpif08, nompi
./quickbuild.sh help To print usage message.
will test on Derecho with the various compilers and mpi libraries once derecho is a back up.

Checklist for merging

Updated changelog entry
Documentation updated
Update conf.py

Checklist for release

Merge into main
Create release from the main branch with appropriate tag
Delete feature-branch

Testing Datasets

Dataset needed for testing available upon request
Dataset download instructions included
No dataset needed

Add mkmf.template.nvhpc in build_templates

…nes)

see #551 for discusion

mpi is the default, but now we have mpif08 as an option I think ./quickbuild.sh mpi should be an allowable thing for a user to run

fixes #282

nancycollins

everything looks fine except i was confused by the "core" lists in the buildfunctions.sh for the mpi vs nompi cases. it's probably how it should be but it looks strange on first read.

nancycollins · 2023-10-24T13:53:37Z

build_templates/buildfunctions.sh


 if [ "$mpisrc" == "mpi" ]; then

   core=${core//$nullmpi/}
   core=${core//$nullwin/}
+   core=${core//$mpif08/}


this looks backwards to me - is it just the labels? mpi includes the nullmpi version, and below the #nompi version includes the mpi modules?

It does look backwards with the // at the beginning, but if you believe me:

core=${core//$nullmpi/}

replace all matches (// ) of$nullmpi from $core with nothing ('/ ')

so for mpi, remove null, nullwin, mpif08, mpif08, no_cray_winf08

fixes: #565

nancycollins

looks good.

hkershaw-brown · 2023-11-06T13:45:32Z

needs converters

nompi mpi - this is for GSI only (no mpif08 code for that converter)

added note on quickbuild.sh help to getting started

mjs2369

https://github.com/NCAR/DART/blob/6c6ac535ff2a75d2b1831b5e414570cf370a3a66/build_templates/buildconvfunctions.sh#L45C1-L55C2

In the function print_usage in buildconvfunctions.sh, it should echo ./quickbuild.sh instead of buildconverter.sh

Also, is line 52 (copied below) true? I don't think that we can build individual programs with obs_converters
echo " buildconverter.sh [program] : build a single program"

Attempting to run ./quickbuild.sh filter while in the work dir for an obs converter results in "ERROR: unknown program filter"

mjs2369 · 2023-11-06T18:19:58Z

guide/compiling-dart.rst

+     quickbuild.sh clean               : clean the build
+     quickbuild.sh help                : print help message
+
+     quickbuild.sh [nompi/nompi/mpif08] [program]   : optional arguments


Suggested change

quickbuild.sh [nompi/nompi/mpif08] [program] : optional arguments

quickbuild.sh [mpi/nompi/mpif08] [program] : optional arguments

fixed in 3af2899

hkershaw-brown · 2023-11-06T19:57:18Z

https://github.com/NCAR/DART/blob/6c6ac535ff2a75d2b1831b5e414570cf370a3a66/build_templates/buildconvfunctions.sh#L45C1-L55C2

In the function print_usage in buildconvfunctions.sh, it should echo ./quickbuild.sh instead of buildconverter.sh

Also, is line 52 (copied below) true? I don't think that we can build individual programs with obs_converters echo " buildconverter.sh [program] : build a single program"

Attempting to run ./quickbuild.sh filter while in the work dir for an obs converter results in "ERROR: unknown program filter"

Fixed buildconverter.sh -> quickbuild.sh

The converter quickbuilds will build a single program, but it has to be one of the converter programs. Do you think it would be less confusing to just have the docs say run ./quickbuild.sh help in a work directory to see the options?

mjs2369 · 2023-11-06T20:12:41Z

The converter quickbuilds will build a single program, but it has to be one of the converter programs. Do you think it would be less confusing to just have the docs say run ./quickbuild.sh help in a work directory to see the options?

I think that is already covered in the docs, unless you mean that running "./quickbuild help" will show the options for possible single programs that can be built for the given work dir, which it currently doesn't do

hkershaw-brown · 2023-11-06T20:19:50Z

The converter quickbuilds will build a single program, but it has to be one of the converter programs. Do you think it would be less confusing to just have the docs say run ./quickbuild.sh help in a work directory to see the options?

I think that is already covered in the docs, unless you mean that running "./quickbuild help" will show the options for possible single programs that can be built for the given work dir, which it currently doesn't do

To address #497, I put in the the usage for quickbuild.sh for lorenz_63.
but it seems like this is confusing for converter builds. What were you thinking for #497 ?

mjs2369 · 2023-11-06T21:22:12Z

To address #497, I put in the the usage for quickbuild.sh for lorenz_63.
but it seems like this is confusing for converter builds. What were you thinking for #497 ?

I really like the additions to the usage for quickbuild.sh for lorenz_63 and think it fixes 497 well. I don't think it's confusing for the obs converters; if they try to use the mpi options it will fail and from there they can use the help command.

But we could maybe add something like "not for obs converters" to this line here

mjs2369

I think the compiling-dart doc is great! Ready to merge

Fixes for remaining documentation warnings in #546

remove loop from Mersenne twister test

Create mkmf.template.nvhpc

doc fix: rename assim_mod_mod docs to match the module

fix: sync filter_mod.dopplerfold with filter_mod

ann-norcio and others added 9 commits October 5, 2023 17:20

Create mkmf.template.nvhpc

73baddf

Add mkmf.template.nvhpc in build_templates

Adding comment about ftn (Derecho/Cray) and nvfortran (non-Cray machi…

fb07add

…nes)

addind IEEE flag

f318a53

add suggested debugging flags

0cbe8b2

removed loop because 1 test is sufficent to find the compiler bug #495

b1ddaf2

comment - for completeness ran_twist is from numerical recipies

960eed1

option for mpif08

ec0a431

mpif08 for quickbuild.sh for models

89621bc

see #551 for discusion

add mpi to the list of optional 1st argumements

851978d

mpi is the default, but now we have mpif08 as an option I think ./quickbuild.sh mpi should be an allowable thing for a user to run

hkershaw-brown marked this pull request as draft October 23, 2023 19:14

fix: nompi needs mpif08 modules removed from list of source files

2ff7237

hkershaw-brown marked this pull request as ready for review October 23, 2023 19:20

hkershaw-brown mentioned this pull request Oct 23, 2023

Feature request: mpif08 github action on pull request #563

Closed

hkershaw-brown requested a review from nancycollins October 23, 2023 19:40

doc fix: rename assim_mod_mod docs to match the module

fa3cf2d

fixes #282

nancycollins reviewed Oct 24, 2023

View reviewed changes

fix: sync filter_mod.dopplerfold with filter_mod

c78fa71

fixes: #565

hkershaw-brown added the release! bundle with next release label Oct 26, 2023

hkershaw-brown requested a review from mjs2369 October 26, 2023 20:51

nancycollins approved these changes Oct 31, 2023

View reviewed changes

hkershaw-brown marked this pull request as draft November 6, 2023 13:45

hkershaw-brown added 3 commits November 6, 2023 07:07

fix: converters need mpif08 removed from list of source files

0cd7030

nompi mpi - this is for GSI only (no mpif08 code for that converter)

typo in usage for quickbuild.sh

d5b3779

doc: added quickbuild.sh usage to compiling dart

4fb221f

added note on quickbuild.sh help to getting started

hkershaw-brown marked this pull request as ready for review November 6, 2023 14:54

Fixes for remaining documentation warnings in #546

0e92728

mjs2369 reviewed Nov 6, 2023

View reviewed changes

hkershaw-brown added 2 commits November 6, 2023 14:47

fix: usage for obs converter quickbuild.sh

7810c6e

fix: usage message mpi/nompi/mpif08 in script and docs

3af2899

doc: add converter quickbuild usage

e39aa8f

mjs2369 approved these changes Nov 7, 2023

View reviewed changes

hkershaw-brown and others added 6 commits November 7, 2023 14:45

bump version and changelog for release

d64061d

Merge pull request #573 from c-merchant/doc_notes

b324e02

Fixes for remaining documentation warnings in #546

Merge pull request #561 from NCAR/random-test-no-loop

45013ee

remove loop from Mersenne twister test

Merge pull request #557 from ann-norcio/add-mkmf.template.nvhpc

251ffb1

Create mkmf.template.nvhpc

Merge pull request #564 from NCAR/doc-rename

dcf9ad0

doc fix: rename assim_mod_mod docs to match the module

Merge pull request #567 from NCAR/sync-dopplerfold

40ad949

fix: sync filter_mod.dopplerfold with filter_mod

hkershaw-brown merged commit 1244b87 into main Nov 7, 2023
3 checks passed

hkershaw-brown deleted the quickbuild-mpif08 branch November 7, 2023 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quickbuild mpif08 #562

Quickbuild mpif08 #562

hkershaw-brown commented Oct 23, 2023 •

edited

Loading

nancycollins left a comment

nancycollins Oct 24, 2023

hkershaw-brown Oct 24, 2023

nancycollins left a comment

hkershaw-brown commented Nov 6, 2023

mjs2369 left a comment

mjs2369 Nov 6, 2023

hkershaw-brown Nov 6, 2023

hkershaw-brown commented Nov 6, 2023

mjs2369 commented Nov 6, 2023

hkershaw-brown commented Nov 6, 2023

mjs2369 commented Nov 6, 2023

mjs2369 left a comment

	quickbuild.sh [nompi/nompi/mpif08] [program] : optional arguments
	quickbuild.sh [mpi/nompi/mpif08] [program] : optional arguments

Quickbuild mpif08 #562

Quickbuild mpif08 #562

Conversation

hkershaw-brown commented Oct 23, 2023 • edited Loading

Description:

Fixes issue

Types of changes

Documentation changes needed?

Tests

Checklist for merging

Checklist for release

Testing Datasets

nancycollins left a comment

Choose a reason for hiding this comment

nancycollins Oct 24, 2023

Choose a reason for hiding this comment

hkershaw-brown Oct 24, 2023

Choose a reason for hiding this comment

nancycollins left a comment

Choose a reason for hiding this comment

hkershaw-brown commented Nov 6, 2023

mjs2369 left a comment

Choose a reason for hiding this comment

mjs2369 Nov 6, 2023

Choose a reason for hiding this comment

hkershaw-brown Nov 6, 2023

Choose a reason for hiding this comment

hkershaw-brown commented Nov 6, 2023

mjs2369 commented Nov 6, 2023

hkershaw-brown commented Nov 6, 2023

mjs2369 commented Nov 6, 2023

mjs2369 left a comment

Choose a reason for hiding this comment

hkershaw-brown commented Oct 23, 2023 •

edited

Loading