Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves errors with documentation build warnings. #570

Closed
wants to merge 2 commits into from

Conversation

c-merchant
Copy link
Collaborator

Description:

Fixes #546. I resolved the warnings introduced when making the docs by removing unreferenced footnotes in clm, resolving indentation issues in lorenz_96_tracer_advection, and adding fluxnetfull to toctree. Branch is also updated to latest main.

Fixes issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
I re-ran the make file without any issues.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown
Copy link
Member

closing this request
Chatted with Charlotte about this, this morning

  • check main on fork is upto date
  • test main - confirm the issue is still there (Brett has already fixed the CLM part)
  • descriptive branch name
  • new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc notes fluxnetfull, lorenz_96_tracer_advection, clm
2 participants