-
Notifications
You must be signed in to change notification settings - Fork 64
CCPP Framework Meeting Minutes 2024 11 07
Attendees: Michael Kavulich, Soren Rasmussen, Dustin Swales, Dom Heinzeller, Jesse Nusbaumer, Michael Waxmonsky, RhaeSung Kim, Jordan Powers, Courtney Peverley
CCPP Framework (issues, PRs, discussions)
-
Add constituent tendency capability PR#584
- Ready to merge!
-
capgen host model DDT problem Issue#589
-
Added test using a DDT host object to pass information #591
- Still waiting on Steve
-
Added test using a DDT host object to pass information #591
-
Unit conversion bug when variable is used by two different schemes (with different units) Issue#594
-
Make full constituents object available via metadata Issue#597
-
xmllint missing from CI jobs Issue#601
- Do we want xmllint to be opt-in or opt-out?
-
Bugfix for auto transforms PR#604
- Some CI failures, they seem familiar...
-
fix errflg variable name in cap #609
- Approved, ready to merge?
Standard names (issues, PRs, discussions)
Will discuss in detail next week, but review these if interested
-
Update StandardNamesRules.rst: add _due_to_planetary_boundary_layer #80
- Fold into ongoing new rules discussion?
-
air_pressure_at_sea_level or air_pressure_at_mean_sea_level or both? Issue#82
- Time to update main branch?
- Mike K can open PR and run UFS WM RTs, will need Navy and CGD to run tests
- Capgen documentation!
- Standard Names governance update
- Supported units
- The question has come up again: what units should we support in CCPP framework?
- https://github.com/NCAR/ccpp-framework/issues/603
Attendees: Michael Kavulich, Soren Rasmussen, Dustin Swales, Dom Heinzeller, Jesse Nusbaumer, Michael Waxmonsky, RhaeSung Kim, Jordan Powers, Courtney Peverley
CCPP Framework
- Waiting on Steve for DDT PR
- People should provide feedback on python support policy (discussion #605)
- Michael W would like to remove at least python 3.8 from the github workflow
- Dom votes for continuing support of 3.9 for a while (since it’s still prevalent in users’ conda environments)
- Michael K - do we have a requirements file?
- Dom - yes, should also update CMakeLists file (to be consistent)
- Tendency PR, unit conversion bugfix PR, errflg update PR ready for merge
- Michael K to merge
- Michael W: Trailing comments regex debugging - would need extra work to support all the different types of comments
- Dustin - Should we make fortran parsing optional?
- Dom - other options for parsing? Third-party libraries?
- Michael W - gfortran can give you abstract syntax tree, which we would then have to parse; might be a python library
- Could have compiler/parser version issues
- Dom - we only support F90-F08, making the older version not compile could force people to update
- Jesse - how strict should we be? Some F90 files have pieces of Fortran 77 code
- Michael K - Seems reasonable to expect people to change to F90
- Dustin - concern about who will do all the work to convert
- Soren - unclear how much F77 code there is; will check
- Could have compiler/parser version issues
- Michael W - gfortran can give you abstract syntax tree, which we would then have to parse; might be a python library
Standard Names
Will discuss next week
Discussion
- Time to update the main branch?
- Dom to run Navy tests; Courtney to run SIMA tests
- Capgen documentation
- Courtney will make an issue?
- Standard names governance update
- Will start versioning standard names & continue discussion in next week’s meeting
- Supported units
- Jesse - if someone wants to add a conversion, they can. They just have to do it. (it’s super simple)
- Michael K - two issues:
- Which units will we convert
- Which units will we allow to pass the parser as “valid”
- Michael W - could use third party library for validity