Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#183 #529

Merged
merged 6 commits into from
Oct 22, 2024
Merged

UFS-dev PR#183 #529

merged 6 commits into from
Oct 22, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 17, 2024

Changes similar to NOAA-EMC/fv3atm#798

Additional changes:

  • Make the interstitial DDT in the SCM physics DDT an array of (n_threads) size so that GFS_Debug can work (this is how UFS does it)
    -- downstream changes for the above change

RT notes: This PR doesn't change RT results except for the addition of a new test that exercise the GFS_debug.F90 schemes. Note that the GFS_abort scheme in GFS_debug.F90 is untested because it causes a run failure (on purpose) and CI flags it as a failure, which we don't necessarily want.

…emes; allocate the Interstitial DDT as an array of size n_threads
@grantfirl grantfirl requested a review from scrasmussen October 22, 2024 15:55
…'t want a failing run (even if it is on purpose) because it will get flagged and fail CI
@grantfirl
Copy link
Collaborator Author

@dustinswales @mkavulich @scrasmussen RTs run as expected now. There were a couple of failures related to the original PR -- one was that I failed to compile the new suite(s) in the RT CI workflow and the second was that, for testing purposes, I include the GFS_abort scheme from GFS_debug.F90 in the new suites, but this sets a non-zero error flag upon run termination and the CI flags it as a failure. All of that is expected, but we don't want to have CI fail from henceforth, so I just removed the GFS_abort scheme. All is good at this point, so I'll go ahead and merge after the ccpp-physics one.

@grantfirl grantfirl merged commit c5c0558 into NCAR:main Oct 22, 2024
22 of 24 checks passed
@grantfirl grantfirl mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants