Ncl Climatology Entry #80
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Meowdy! See your PR preview: |
|
Just noting that pre-commit is failing because of image(s) again and nothing else. |
Actually in this case I think it is failing because of It doesn't seem to like OND very much |
|
To address the "OND" issue (if you want), you could add in a pyproject.toml text file to the base directory of the repository with a configuration option to ignore that set of letters. You can see an example over on geocat-comp. You should only need the following lines though: There's another way to do this with a |
Co-authored-by: Andy McKeen <[email protected]>
kafitzgerald
added
the
blocked
kafitzgerald
removed
the
blocked
| @@ -0,0 +1,313 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch.
I'll go in and add some custom titles that won't take up so much space.
I could probably add the semicolon after the plot as well to avoid the matplotlib lines above the figures as well.
Removing the figures altogether is another option (and would be more concise), but I think I'll leave that call for later.
| @@ -0,0 +1,313 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,313 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -9,8 +9,15 @@ NCL Function,Description,Python Equivalent,Notes | |||
| `cosh <https://www.ncl.ucar.edu/Document/Functions/Built-in/cosh.shtml>`__,"Computes the hyperbolic cosine of numeric types","``math.cosh()`` or ``numpy.cosh()``",`example notebook <../ncl_entries/trigonometric_functions.ipynb#cosh>`__ | |||
| `sinh <https://www.ncl.ucar.edu/Document/Functions/Built-in/sinh.shtml>`__,"Computes the hyperbolic sine of numeric types","``math.sinh()`` or ``numpy.sinh()``",`example notebook <../ncl_entries/trigonometric_functions.ipynb#sinh>`__ | |||
| `tanh <https://www.ncl.ucar.edu/Document/Functions/Built-in/tanh.shtml>`__,"Computes the hyperbolic tangent of numeric types","``math.tanh()`` or ``numpy.tanh()``",`example notebook <../ncl_entries/trigonometric_functions.ipynb#tanh>`__ | |||
| `days_in_month <https://www.ncl.ucar.edu/Document/Functions/Built-in/days_in_month.shtml>`__,"Calculates the number of days in a month given month and year","``cftime.datetime().daysinmonth``",`example notebook <../ncl_entries/days_in_month.ipynb>`__ | |||
There was a problem hiding this comment.
Should these be alphabetical? It looks like they're not rendered in the same order as this table anyway - but not quite alphabetical either.
There was a problem hiding this comment.
A similar thought process led me to logging this issue (better table functionality including sorting): #119
I was leaning toward leaving it for now and sorting things out later when addressing that issue, but could be convinced otherwise.
There was a problem hiding this comment.
Yeah separate PR for sure. Thanks for making that issue
|
I think there's still some room to polish up the plots here, but I think that can happen later. Maybe as part of some project-wide formatting / style work. I'm going to get this merged. |
PR Summary