-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PyPI trusted publishing #80
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few comments below, it looks good to me
.github/workflows/pypi.yaml
Outdated
@@ -33,7 +35,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be too old. Their latest version is v5 I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was updated in a separate PR where dependabot was added to avoid this in the future.
I think those changes should be reflected now.
Relates to #69
Additional changes are also needed to the repo and PyPI settings. See here: NCAR/geocat-comp#534