Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPI trusted publishing #80

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kafitzgerald
Copy link
Collaborator

Relates to #69

Additional changes are also needed to the repo and PyPI settings. See here: NCAR/geocat-comp#534

Copy link
Collaborator

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few comments below, it looks good to me

.github/workflows/pypi.yaml Show resolved Hide resolved
@@ -33,7 +35,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be too old. Their latest version is v5 I believe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated in a separate PR where dependabot was added to avoid this in the future.

I think those changes should be reflected now.

.github/workflows/pypi.yaml Outdated Show resolved Hide resolved
@kafitzgerald kafitzgerald added the blocked Work got blocked waiting the output of some other source/work label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work got blocked waiting the output of some other source/work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants