Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalized implementation of new lake shape options in the levelpool simulations #508

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Finalized implementation of new lake shape options in the levelpool simulations #508

wants to merge 12 commits into from

Commits on Jul 24, 2020

  1. new shape options were added to levelpool module. LAKEPARM.nc and hyd… 

    …ro.namelist were modified accordingly.
    Bahram Khazaei authored and Bahram Khazaei committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    c6b5070 View commit details
    Browse the repository at this point in the history

  2. adjustments made to levelpool physics and also reading the new variab… 

    …les from LAKEPARM file
    Bahram Khazaei committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5a708d2 View commit details
    Browse the repository at this point in the history

  3. fix minor issue in levelpool code

    Bahram Khazaei committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    0a21b45 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Add default value of 0 for lake_shape_option

    @rcabell
    rcabell committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    314369b View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Update the code to read from old LAKEPARM file when lake_shape_option… 

    … is not defined or defined 0
    Bahram Khazaei committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    13f0f58 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Switched back dh calculations in LP to old scheme to check for diffs … 

    …in engineering tests
    Bahram Khazaei committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    b2fdc1f View commit details
    Browse the repository at this point in the history

  2. Update LP to debug issues related to calculation of dh in shape option 0

    Bahram Khazaei committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    d3815c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Add Lake Shape arguments to READ_CHROUTING1 et al

    @rcabell
    rcabell committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    a2e0636 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. removed print statments used for testing lake shape option

    Bahram Khazaei committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    79260ed View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. fixed typo in lake shape options rectangular --> triangular

    Bahram Khazaei committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2de7eff View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Update module_HYDRO_io.F 

    Changed if(nlst(did)%lake_shape_option /= 0) to if(nlst(did)%lake_shape_option >= 0) in Routing/module_HYDRO_io.F to make pass-through scheme work if new LAKEPARM variables are not provided (backward compatible with LAKEPARM v2.1 and before).
    @BahramKhazaei-NOAA
    BahramKhazaei-NOAA authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    aef24cb View commit details
    Browse the repository at this point in the history

  2. Update module_HYDRO_io.F 

    Changed >=0 to > 0
    @BahramKhazaei-NOAA
    BahramKhazaei-NOAA authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bc67979 View commit details
    Browse the repository at this point in the history