Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Plotting for New CI #748

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented May 8, 2024

TYPE: bugfix

KEYWORDS: CI, Github Actions

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: This fixes paths for the new CI. When there's a difference in output from PR changes, plots are generated and need to be copied into a directory that gets zipped as an artifact. Commit is copied from testing/new-ci-plotting branch. See "Tests Conducted" section.

TESTS CONDUCTED:

  • Commit 5e9d1a4 from the testing/new-ci-plotting branches changes constants so the output from the CI run is different
  • Commit 1bd34d5 (which is the same as this PR's 5e309a3) has the changes to paths so the correct directories and files are copied to the test-report artifact.
  • See test-reports at bottom of CI run.

NOTES: Once this is merged PR#747 can be closed.

TODO:

  • put plots in the comments

Checklist

  • Closes issue #xxxx
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

@scrasmussen
Copy link
Member Author

Plots are now attaching, as seen in the test PR. There seems to be an issue when all cases are trying to push the images to the same branch but at least some are getting through. The github artifact does have all of the plots though

…e in output from PR changes

Updating scripts to work with new Github CI
@scrasmussen scrasmussen merged commit 0d6e743 into NCAR:main Sep 26, 2024
4 checks passed
@rcabell rcabell added this to the WRF-Hydro v5.4 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants