Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record dimension coordinate cell characteristics #693

Merged
merged 10 commits into from
Sep 23, 2023
Merged

Record dimension coordinate cell characteristics #693

merged 10 commits into from
Sep 23, 2023

Conversation

davidhassell
Copy link
Collaborator

Fixes #692

@davidhassell davidhassell added the aggregation Rerlating to metadata-based field and domain aggregation label Sep 19, 2023
@davidhassell davidhassell added this to the Next release milestone Sep 19, 2023
sadielbartholomew
sadielbartholomew approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. Implementation is elegant and testing is thorough. I've made some minor suggestions, mostly to fix repeat/copy-and-pasted typos, but this is all good overall so please merge when ready. Thanks.

cf/aggregate.py Outdated Show resolved Hide resolved
cf/aggregate.py Show resolved Hide resolved
Changelog.rst Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
cf/dimensioncoordinate.py Outdated Show resolved Hide resolved
sadielbartholomew
sadielbartholomew reviewed Sep 22, 2023
View reviewed changes
cf/aggregate.py Outdated Show resolved Hide resolved
davidhassell and others added 5 commits September 23, 2023 09:14
@davidhassell @sadielbartholomew
Typo
7ca42e0 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typos
fecc7b6 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typos
1c3725b 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typo
f0634f4 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Docs
929e650 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 2cfc8e6 into NCAS-CMS:main Sep 23, 2023
@davidhassell davidhassell deleted the aggregation-cell branch September 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
aggregation Rerlating to metadata-based field and domain aggregation
Projects
None yet
Milestone
3.15.4
Development

Successfully merging this pull request may close these issues.

Record cell characteristics from aggregation cell conditions
2 participants
@davidhassell @sadielbartholomew