Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in certain cyclic subsets #782

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Fix bug in certain cyclic subsets #782

merged 5 commits into from
Jun 11, 2024

Conversation

mattjbr123
Copy link
Contributor

To fix #774

  • Modified normalize_slice in cf/functions.py
  • Added test to check confirm behaviour in cf/test/test_functions.functionTest.test_normalize_slice
  • Added changes to changelog.

@mattjbr123 mattjbr123 mentioned this pull request Jun 7, 2024
Closed
davidhassell
davidhassell approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@davidhassell davidhassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt,

All good - thanks! If you could look at the one very minor change to the Changelog, and would you like to add your name to the contributors list in docs/source/contributing.rst?

Changelog.rst Outdated Show resolved Hide resolved
@davidhassell davidhassell added this to the NEXT VERSION milestone Jun 11, 2024
@davidhassell davidhassell added the bug Something isn't working label Jun 11, 2024
@mattjbr123
Copy link
Contributor Author

Sure thing, all done :)

@davidhassell
Copy link
Collaborator

Great, merging now. We'll be pushing out a the new version in the next few weeks (at least by the 8th July). Thanks again, Matt!

@davidhassell davidhassell merged commit 2d183c8 into NCAS-CMS:main Jun 11, 2024
@mattjbr123 mattjbr123 deleted the fix_cyclic_subset_bug branch June 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhassell davidhassell davidhassell approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
NEXT VERSION
Development

Successfully merging this pull request may close these issues.

Certain cyclic slices fail when subsetting in 3.16.2 vs 3.16.1
2 participants
@mattjbr123 @davidhassell