Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New method: cf.Field.filled #812

Merged
merged 6 commits into from
Sep 9, 2024
Merged

New method: cf.Field.filled #812

merged 6 commits into from
Sep 9, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #811

@davidhassell davidhassell added the enhancement New feature or request label Sep 3, 2024
@davidhassell davidhassell added this to the NEXT VERSION milestone Sep 3, 2024
sadielbartholomew
sadielbartholomew approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've raised a pair of minor comments regarding the docstring parameter descriptions, but otherwise this is all good so please merge when you are ready. Thanks.

cf/mixin/propertiesdata.py Outdated Show resolved Hide resolved
cf/mixin/propertiesdatabounds.py Outdated Show resolved Hide resolved
cf/mixin/propertiesdatabounds.py Outdated Show resolved Hide resolved
cf/mixin/propertiesdata.py Outdated Show resolved Hide resolved
davidhassell and others added 4 commits September 9, 2024 18:22
@davidhassell @sadielbartholomew
Typo
a6b70d8 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typo
fbb7ee6 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typo
043087a 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typo
ba5b706 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell
Copy link
Collaborator Author

Hi Sadie - good catches on those method names - they were throwbacks to some cfdm text that I blindly copied!

@davidhassell davidhassell merged commit 4088c60 into NCAS-CMS:main Sep 9, 2024
@davidhassell davidhassell deleted the filled branch September 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
NEXT VERSION
Development

Successfully merging this pull request may close these issues.

New method: cf.Field.filled
2 participants
@davidhassell @sadielbartholomew