-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some packaging improvements #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black magic. What exactly is the nightly test doing? Just testing it builds ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it builds the environment, installs the tool, then it checks a basic s3view --help
and which s3view
- of course, this will contain at least a pytest -n 2
as soon as unit/integration tests become available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd quite like to put dependencies on particular branches (for now), that I'd do like this with pip:
pip install git+https://github.com/davidhassell/cfdm.git@h5-read-hdf5-chunks-hack
, how would we do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is how it's done: here, with the main
branch of the main repo, change as you like 3d11bf4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nay bother, did that for you in last commit a8f1611
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am happy to go with this, once we've worked out how to do the correct dependencies
cheers @bnlawrence - here's how to do it 3d11bf4 with that dev branch of CFDM added in a8f1611 |
@bnlawrence I have just retired the use of Mambaforge (being sunsetted right now, retired fully in January 2025) - you good to merge this PR? 🍺 |
hi @bnlawrence awesome little tool! Here are a couple minor package improvements 🍺
.gitignore
file to stash unwanted crapenvironment.yml
setup.py
to hold all needed deps