Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some packaging improvements #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Some packaging improvements #3

wants to merge 7 commits into from

Conversation

valeriupredoi
Copy link

hi @bnlawrence awesome little tool! Here are a couple minor package improvements 🍺

  • add .gitignore file to stash unwanted crap
  • add dedicated conda deps file environment.yml
  • add a barebones GA test
  • mod setup.py to hold all needed deps

@valeriupredoi valeriupredoi added the enhancement New feature or request label Jul 9, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black magic. What exactly is the nightly test doing? Just testing it builds ok?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it builds the environment, installs the tool, then it checks a basic s3view --help and which s3view - of course, this will contain at least a pytest -n 2 as soon as unit/integration tests become available

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd quite like to put dependencies on particular branches (for now), that I'd do like this with pip:
pip install git+https://github.com/davidhassell/cfdm.git@h5-read-hdf5-chunks-hack, how would we do that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is how it's done: here, with the main branch of the main repo, change as you like 3d11bf4

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nay bother, did that for you in last commit a8f1611

Copy link
Contributor

@bnlawrence bnlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am happy to go with this, once we've worked out how to do the correct dependencies

@valeriupredoi
Copy link
Author

valeriupredoi commented Jul 12, 2024

Am happy to go with this, once we've worked out how to do the correct dependencies

cheers @bnlawrence - here's how to do it 3d11bf4 with that dev branch of CFDM added in a8f1611
Change as you please 😁 To note also to @davidhassell that the PyPI recipe will mean the user installs udunits2 separately 👍 (which I took care of here in our conda env)

@valeriupredoi
Copy link
Author

@bnlawrence I have just retired the use of Mambaforge (being sunsetted right now, retired fully in January 2025) - you good to merge this PR? 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants