Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to PFOCR's API #132

Closed
AlexanderPico opened this issue Sep 26, 2023 · 3 comments
Closed

Tweaks to PFOCR's API #132

AlexanderPico opened this issue Sep 26, 2023 · 3 comments
Labels

Comments

@AlexanderPico
Copy link

https://github.com/NCATS-Tangerine/translator-api-registry/blob/master/pfocr/smartapi.yaml#L758

I plan to swap in pfocrURL to replace figureURL as the ref_url in the registry (once we've updated the source data at BTE).

I would also like to include a new field to continue to pass along the figureURL for potential UI usage, but I'm not sure which field key to use...

@AlexanderPico
Copy link
Author

https://biothings.transltr.io/pfocr/query?q=associatedWith.pmc:PMC3255783&all

Both figureUrl and pfocrUrl should be ingested by xbte annotation, per Slack discussion with @colleenXu

@colleenXu
Copy link
Collaborator

colleenXu commented Jun 4, 2024

Can close once the linked TRAPI 1.5 issue is closed (aka all stuff is deployed in prod) and the PR linked below is merged.

This is updated on dev/CI right now, but we'll revert it temporarily while pushing the Octopus patch.

@colleenXu
Copy link
Collaborator

Closing this issue:

This will hopefully resolve some confusion...

@colleenXu colleenXu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants