Fix linting errors & use ES6 JS in EML 211 Editor View (Editor cleanup, part 1) #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused render renderChildren function and fix JSdocs in EML211EditorView Issue #2565
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Missing from the template methods Issue #2565
rushirajnenuji
approved these changes
Dec 17, 2024
rushirajnenuji
approved these changes
Dec 17, 2024
rushirajnenuji
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple code clean-up of the
EML211EditorView. It doesn't change the logic or structure of the view, but just lints and modernizes the existing code. This is the first part of issue #2565editor.htmltemplate in favour of inline-template literals