Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor course video player page #108

Merged
merged 2 commits into from
May 18, 2022

Conversation

Xanonymous-GitHub
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub commented May 18, 2022

Description

How to Verify?

  • Open a course detail
  • go to iplus file and choose a video
  • play it

Screenshots/GIF/Test Results (Optional)

截圖 2022-05-19 上午4 55 51

@Xanonymous-GitHub Xanonymous-GitHub added type: bug Something isn't working type: enhancement New feature or request labels May 18, 2022
@Xanonymous-GitHub Xanonymous-GitHub added this to the 1.4.1 milestone May 18, 2022
@Xanonymous-GitHub Xanonymous-GitHub self-assigned this May 18, 2022
@Xanonymous-GitHub Xanonymous-GitHub linked an issue May 18, 2022 that may be closed by this pull request
@Xanonymous-GitHub
Copy link
Member Author

Need to handle the PlatformException when video is not found or some other errors occurred when video player playing the video.

@Xanonymous-GitHub
Copy link
Member Author

Xanonymous-GitHub commented May 18, 2022

Found error while downloading video. (#110)

@Xanonymous-GitHub Xanonymous-GitHub merged commit 2449c17 into master May 18, 2022
@Xanonymous-GitHub Xanonymous-GitHub deleted the refactor-course-video-player-page branch May 18, 2022 21:10
Xanonymous-GitHub added a commit that referenced this pull request Mar 28, 2023
* refactor: migrate to null safety

* refactor: simplify route function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug: Internal Video Player not fitted in SafeArea
1 participant