Hard disable landscape on ios platform #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanonymous-GitHub
deleted the
fix-orientation-not-restricted-on-portrait
branch
Xanonymous-GitHub
changed the title
Xanonymous-GitHub
added a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mentioned in #165, the App seems not restricted to only portrait mode since upgraded to flutter 3.7.
Due to the priority decision, we decided to postpone this issue to next version.
So in this PR, we have directly remove all possibility of using landscape mode in App. This also makes user not be able to use the landscape mode in the video page too.
How to Verify?
In iOS, try to rotate device to landscape form, check if the App had changed its orientation type.
Screenshots/GIF/Test Results (Optional)