Use common variable for TLS #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #248 This is something between a workaround and a partial solution. While it makes more sense to use a role related variable for both Logstash and Elasticsearch output (other than before) it's still not the goal we want. So overhauling the whole process of determining whether we need TLS or not is due. I'll start a discussion and we need to adjust all roles to the solution we find. Now there are similarities but it's not exactly the same in every role.
|
Is the documentation still valid with these changes? |
|
... I hope, I didn't miss anything. But I'll have a second look. |
|
@widhalmt Can I push documentation for |
|
@danopt of course! Go ahead. |
|
Whats going on here? Can i merge main? Are you still working on changes? |
|
@lcndsmr sorry for the eternal wait... yes, the documentation already has the new variables. So this fix actually makes code matching the docs better. |
|
@lcndsmr could you recheck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #248
The
metricbeat.ymlandauditbeat.ymltemplates have code for both connecting to Logstash or Elasticseach. They used different variables to determine whether to turn on TLS or not. That resulted in a missing default and therefore Beats setup breaking when connecting to Elasticseach. I changed the variable that's queried to determine whether to turn on TLS or not.This is something between a workaround and a partial solution. While it makes more sense to use a role related variable for both Logstash and Elasticsearch output (other than before) it's still not the goal we want.
So overhauling the whole process of determining whether we need TLS or not is due. I'll start a discussion and we need to adjust all roles to the solution we find. Now there are similarities but it's not exactly the same in every role.