Fix/schedule for kics #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the tests that ran I see KICS two times. Once for the push and once for the pull request. What do you think how should we get rid of one of the tests? Just use |
|
I would not add it to As you can see in this PR, the action is triggered twice. One for |
tbauriedel
requested changes
Nov 5, 2024
tbauriedel
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce 2 new incidents that will trigger a KICS (security scan) run:
push. We can rework that later. But it should be the fastest way of getting results into https://github.com/NETWAYS/ansible-collection-elasticstack/security right now. Which will help with assigning tasks.This will fix the fact that KICS only runs on Pull Requests but does not work as code scanning utility the way GitHub means it.