-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind providers to a model state #1057
Conversation
d315722
to
119e48d
Compare
@LuisDuarte1 @thePeras I included several TODOs with the refactors yet to do. Can you help with them? I'll be quite busy for the next two/three weeks, and this is a bit unstable now. |
There is only left to refactor the lectures page consumer |
a990b0d
to
70d5f59
Compare
53abc28
to
f9e90b0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1057 +/- ##
========================================
+ Coverage 16% 17% +1%
========================================
Files 207 206 -1
Lines 6483 6381 -102
========================================
+ Hits 1004 1032 +28
+ Misses 5479 5349 -130 |
c12c06a
to
6e05bee
Compare
6e05bee
to
cd0eb29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lectures page lost its refresh feature when it's empty, but that will be cover by #909.
Nice work deleting more than 200 lines in this refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #1056
Closes #726
This PR greatly restricts the Provider usage and makes its usage more compact, without the
RequestDependantWidgetBuilder
. It also makes accesses to SharedPreferences synchronous.LazyConsumer
now forces the handling of an empty state, which forces a refactor of several widgets.Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change