Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind providers to a model state #1057

Merged
merged 17 commits into from
Dec 27, 2023
Merged

Conversation

bdmendes
Copy link
Collaborator

@bdmendes bdmendes commented Dec 14, 2023

Closes #1056
Closes #726

This PR greatly restricts the Provider usage and makes its usage more compact, without the RequestDependantWidgetBuilder. It also makes accesses to SharedPreferences synchronous.
LazyConsumer now forces the handling of an empty state, which forces a refactor of several widgets.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bdmendes bdmendes force-pushed the refactor/provider-unique-state branch from d315722 to 119e48d Compare December 14, 2023 22:03
@bdmendes
Copy link
Collaborator Author

@LuisDuarte1 @thePeras I included several TODOs with the refactors yet to do. Can you help with them? I'll be quite busy for the next two/three weeks, and this is a bit unstable now.

@thePeras
Copy link
Member

thePeras commented Dec 18, 2023

There is only left to refactor the lectures page consumer

@bdmendes bdmendes force-pushed the refactor/provider-unique-state branch from a990b0d to 70d5f59 Compare December 23, 2023 14:25
@bdmendes bdmendes marked this pull request as ready for review December 23, 2023 14:25
@bdmendes bdmendes force-pushed the refactor/provider-unique-state branch from 53abc28 to f9e90b0 Compare December 23, 2023 14:30
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Merging #1057 (cd0eb29) into develop (8c09035) will increase coverage by 1%.
Report is 1 commits behind head on develop.
The diff coverage is 21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1057    +/-   ##
========================================
+ Coverage       16%     17%    +1%     
========================================
  Files          207     206     -1     
  Lines         6483    6381   -102     
========================================
+ Hits          1004    1032    +28     
+ Misses        5479    5349   -130     

@bdmendes bdmendes force-pushed the refactor/provider-unique-state branch from c12c06a to 6e05bee Compare December 25, 2023 23:34
@bdmendes bdmendes force-pushed the refactor/provider-unique-state branch from 6e05bee to cd0eb29 Compare December 26, 2023 00:00
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lectures page lost its refresh feature when it's empty, but that will be cover by #909.

Nice work deleting more than 200 lines in this refactor!

@bdmendes bdmendes requested a review from a team December 26, 2023 16:34
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bdmendes bdmendes merged commit 435464e into develop Dec 27, 2023
6 checks passed
@bdmendes bdmendes deleted the refactor/provider-unique-state branch December 27, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind Providers to models Bring back print service
3 participants