Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/same day exams display #1059

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Conversation

vitormpp
Copy link
Member

@vitormpp vitormpp commented Dec 17, 2023

Closes #437
Updated logic to identify and showcase all exams occurring on the same day as the next scheduled exam.
Adjusted rendering to display exams occurring on the same day as the next scheduled exam with additional information (such as start time and exam rooms).
Split the existing ExamCard class into three distinct classes: NextExamsWidget (designed to display both the next scheduled exam and the exams occurring on the same day), RemainingExamsWidget (handles the display of exams occurring after the next scheduled exam), and ExamCard (manages these specialized widgets).

Single next scheduled exam:

1exam

Multiple exams scheduled on the same day as the next exam:

2exams

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@vitormpp vitormpp linked an issue Dec 17, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Merging #1059 (8054160) into develop (17582d6) will decrease coverage by 0%.
Report is 2 commits behind head on develop.
The diff coverage is 2%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1059   +/-   ##
=======================================
- Coverage       16%     16%   -0%     
=======================================
  Files          213     215    +2     
  Lines         6544    6549    +5     
=======================================
  Hits          1044    1044           
- Misses        5500    5505    +5     

uni/lib/view/home/widgets/exam_card.dart Outdated Show resolved Hide resolved
uni/lib/view/home/widgets/exam_card.dart Outdated Show resolved Hide resolved
@bdmendes bdmendes self-requested a review January 19, 2024 14:09
@bdmendes bdmendes requested a review from a team January 26, 2024 14:33
Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, very clean code! Just a minor thing to go.

uni/lib/view/home/widgets/remaining_exams_card.dart Outdated Show resolved Hide resolved
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thePeras thePeras merged commit 613e378 into develop Feb 7, 2024
6 checks passed
@thePeras thePeras deleted the feature/same-day-exams-display branch February 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same day exams display
4 participants