-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/same day exams display #1059
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1059 +/- ##
=======================================
- Coverage 16% 16% -0%
=======================================
Files 213 215 +2
Lines 6544 6549 +5
=======================================
Hits 1044 1044
- Misses 5500 5505 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, very clean code! Just a minor thing to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🛫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #437
Updated logic to identify and showcase all exams occurring on the same day as the next scheduled exam.
Adjusted rendering to display exams occurring on the same day as the next scheduled exam with additional information (such as start time and exam rooms).
Split the existing ExamCard class into three distinct classes: NextExamsWidget (designed to display both the next scheduled exam and the exams occurring on the same day), RemainingExamsWidget (handles the display of exams occurring after the next scheduled exam), and ExamCard (manages these specialized widgets).
Single next scheduled exam:
Multiple exams scheduled on the same day as the next exam:
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change