Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping classes bugs #973

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

LuisDuarte1
Copy link
Member

The overlapping lectures are not completely fixed, because the desired behavior will require a more deep refactor. Now if a overlapping lectures is from a group of classes, the end time will be equal do the start time. I'll create a issue for a more in-depth refactor

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@LuisDuarte1 LuisDuarte1 force-pushed the hotfix/overlapping-classes branch from f8924c6 to 2536062 Compare September 27, 2023 16:08
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #973 (e88317d) into master (a721c1a) will increase coverage by 1%.
Report is 3 commits behind head on master.
The diff coverage is 45%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #973   +/-   ##
=====================================
+ Coverage      22%    22%   +1%     
=====================================
  Files         143    143           
  Lines        4357   4368   +11     
=====================================
+ Hits          948    953    +5     
- Misses       3409   3415    +6     

@LuisDuarte1 LuisDuarte1 merged commit 1ade4ec into master Sep 28, 2023
@LuisDuarte1 LuisDuarte1 deleted the hotfix/overlapping-classes branch September 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant