Revise Rust CI workflow. #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
reviewed
Jun 20, 2024
| @@ -3,22 +3,33 @@ on: | |||
| workflow_call: | |||
| inputs: | |||
| rust_msrv: | |||
| description: The minimum support Rust version for your project, e.g. 1.71.0. | |||
| description: > | |||
| The minimum support Rust version to test the project with, | |||
There was a problem hiding this comment.
Suggested change
| The minimum support Rust version to test the project with, | |
| The minimum supported Rust version to test the project with, |
ximon18
reviewed
Jun 20, 2024
| description: Test using minimal dependency versions from Cargo.toml. | ||
| test_minimal_version: | ||
| description: > | ||
| If non-empty, test using minimal dependency versions from Cargo.toml |
There was a problem hiding this comment.
This description fails to mention that the string should be a Rust version number, I think that would be helpful.
ximon18
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes a revised Rust CI workflow that follows along the lines of what we are doing for domain now. It adds a new input variable and changes the meaning of another one …